This includes D13883.
Details
- I'll confirm that staging successfully deploys without issue
- Once staging is deployed, I'll confirm that I'm still able to log in to staging identity
I won't land this until both are confirmed.
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
- I'll confirm that staging successfully deploys without issue
- Once staging is deployed, I'll confirm that I'm still able to log in to staging identity
I won't land this until both are confirmed.
Test plan is concluded
We normally wait a day before promoting a version from staging to prod
I don't love that we're breaking precedent here, but since we are, I compared 0.44 and 0.45 on GitHub to make sure we're not accidentally including any other changes. I don't see any changes to shared/ or services/identity besides the ones in D13883, so this appears safe
That's fair – I probably should've preempted this concern and explained my reasoning.
My perspective is basically what you've described... the only change here is D13883, and it simply removes a check that can cause a fatal. In contrast with D13881 which triggered my "spidey senses" a bit, this change feels almost certainly safe to me.