[native][web] Flip the switch for blob-hosted media/avatar uploads
AcceptedPublic
Actions

Authored by bartek on Thu, Nov 7, 3:43 AM.

Details

Reviewers

ashoat

Commits

rCOMMb1a48f05876f: [native][web] Flip the switch for blob-hosted media/avatar uploads

Summary

Flip the switch for enabling blob-hosted multimedia.

Depends on D13890

Test Plan

Verified in MariaDB that new uploads have empty content column and instead have the (blob hash, holder) pair.
Checked native/web, both avatars and multimedia meessages.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Thu, Nov 7, 3:43 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptThu, Nov 7, 3:43 AM

bartek added a child revision: D13892: [native][web] Clean up dead conditions for media encryption.Thu, Nov 7, 3:46 AM

Harbormaster completed remote builds in B32571: Diff 45658.Thu, Nov 7, 4:10 AM

bartek published this revision for review.Thu, Nov 7, 4:51 AM

bartek added inline comments.

native/avatars/avatar-hooks.js
47	These hardcoded values are removed in D13892

ashoat accepted this revision.Thu, Nov 7, 5:32 AM

This revision is now accepted and ready to land.Thu, Nov 7, 5:32 AM

Closed by commit rCOMMb1a48f05876f: [native][web] Flip the switch for blob-hosted media/avatar uploads (authored by bartek). · Explain WhyThu, Nov 7, 8:25 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMb1a48f05876f: [native][web] Flip the switch for blob-hosted media/avatar uploads.

ashoat added a reverting change: rCOMMeea1df0f6502: Revert "[native][web] Flip the switch for blob-hosted media/avatar uploads".Thu, Nov 7, 7:13 PM

ashoat reopened this revision.Thu, Nov 7, 7:13 PM

This revision is now accepted and ready to land.Thu, Nov 7, 7:13 PM

Reverted this diff because blob-hosted multimedia in thin threads will get shimmed by the keyserver to recent mobile clients.

Even ignoring the fact that the current latest builds (after unpublishing 437 and 438, see ENG-9890) will fail to unshim blob-hosted multimedia messages, it's still probably not a good idea to launch this when only the latest mobile version is able to unshim the messages. The UX experience of being unable to see somebody's photo is pretty negative.

This should probably be addressed in D13888 by updating the keyserver to stop shimming for not just the most recent codeVersion, but rather for any codeVersion that supports blob-hosted multimedia messages. Once that change is made, I think this would be safe to land again.