Page MenuHomePhabricator

[native][web] Flip the switch for blob-hosted media/avatar uploads
ClosedPublic

Authored by bartek on Nov 7 2024, 3:43 AM.
Tags
None
Referenced Files
F3522895: D13891.id45729.diff
Mon, Dec 23, 7:50 AM
F3522894: D13891.id45696.diff
Mon, Dec 23, 7:50 AM
F3522892: D13891.id45658.diff
Mon, Dec 23, 7:50 AM
F3522877: D13891.id.diff
Mon, Dec 23, 7:50 AM
F3522868: D13891.diff
Mon, Dec 23, 7:50 AM
Unknown Object (File)
Thu, Dec 19, 4:24 AM
Unknown Object (File)
Thu, Dec 19, 3:40 AM
Unknown Object (File)
Wed, Dec 18, 9:50 PM
Subscribers

Details

Summary

Flip the switch for enabling blob-hosted multimedia.

Depends on D13890

Test Plan

Verified in MariaDB that new uploads have empty content column and instead have the (blob hash, holder) pair.
Checked native/web, both avatars and multimedia meessages.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Nov 7 2024, 4:51 AM
bartek added inline comments.
native/avatars/avatar-hooks.js
47

These hardcoded values are removed in D13892

This revision is now accepted and ready to land.Nov 7 2024, 5:32 AM
This revision is now accepted and ready to land.Nov 7 2024, 7:13 PM

Reverted this diff because blob-hosted multimedia in thin threads will get shimmed by the keyserver to recent mobile clients.

Even ignoring the fact that the current latest builds (after unpublishing 437 and 438, see ENG-9890) will fail to unshim blob-hosted multimedia messages, it's still probably not a good idea to launch this when only the latest mobile version is able to unshim the messages. The UX experience of being unable to see somebody's photo is pretty negative.

This should probably be addressed in D13888 by updating the keyserver to stop shimming for not just the most recent codeVersion, but rather for any codeVersion that supports blob-hosted multimedia messages. Once that change is made, I think this would be safe to land again.