[CommCoreModule] make sure `backupID` is URL-safe string
ClosedPublic
Actions

Authored by kamil on Nov 7 2024, 3:17 PM.

Details

Reviewers

varun
bartek

Commits

rCOMMa2b0d2a52444: [CommCoreModule] make sure `backupID` is URL-safe string

Summary

ENG-9728.

Not sure if we need any additional conversion, this should be enough.

Test Plan

Test uploading backup

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 7 2024, 3:17 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 7 2024, 3:17 PM

Harbormaster completed remote builds in B32577: Diff 45692.Nov 7 2024, 3:37 PM

kamil published this revision for review.Nov 7 2024, 4:13 PM

varun accepted this revision.Nov 7 2024, 7:38 PM

This revision is now accepted and ready to land.Nov 7 2024, 7:38 PM

Closed by commit rCOMMa2b0d2a52444: [CommCoreModule] make sure `backupID` is URL-safe string. · Explain WhyNov 12 2024, 12:14 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa2b0d2a52444: [CommCoreModule] make sure `backupID` is URL-safe string.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

CryptoTools/

Tools.h

1 line

Tools.cpp

6 lines

NativeModules/

CommCoreModule.cpp

2 lines

Diff 45734

View Options

native/cpp/CommonCpp/CryptoTools/Tools.h

View Options

native/cpp/CommonCpp/CryptoTools/Tools.cpp

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[CommCoreModule] make sure `backupID` is URL-safe stringClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45734

native/cpp/CommonCpp/CryptoTools/Tools.h

native/cpp/CommonCpp/CryptoTools/Tools.cpp

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[CommCoreModule] make sure `backupID` is URL-safe string
ClosedPublic
Actions

Revision Contents
Changeset List