Page MenuHomePhabricator
Differential D13950

[native] Make sure all virtual classes in C++ code base have virtual destructor
Needs ReviewPublic
Actions

Authored by angelika on Fri, Nov 15, 1:26 PM.

Details

Reviewers
kamil
tomek
Summary

https://linear.app/comm/issue/ENG-2329/make-sure-all-virtual-classes-in-c-code-base-have-virtual-destructor

Test Plan

Compile the app and make sure there are no more warnings related to missing virtual destructors

Diff Detail

Repository
rCOMM Comm
Branch
graszka22/ENG-2329
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
1 line
NativeModules/
PersistentStorageUtilities/
MessageOperationsUtilities/
MessageSpecs/
2 lines
web/
shared-worker/
_generated/

Diff 45853

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/MessageSpec.h

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...