Page MenuHomePhabricator
Differential D13950

[native] Make sure all virtual classes in C++ code base have virtual destructor
ClosedPublic
Actions

Authored by angelika on Nov 15 2024, 1:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 8, 4:12 PM
Unknown Object (File)
Fri, Jan 3, 12:47 PM
Unknown Object (File)
Mon, Dec 30, 3:41 AM
Unknown Object (File)
Sat, Dec 28, 1:15 AM
Unknown Object (File)
Sat, Dec 21, 8:27 PM
Unknown Object (File)
Sat, Dec 21, 8:26 PM
Unknown Object (File)
Mon, Dec 16, 12:26 PM
Unknown Object (File)
Dec 3 2024, 7:58 PM
View All 20 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM7a608523bf85: [native] Make sure all virtual classes in C++ code base have virtual destructor
Summary

https://linear.app/comm/issue/ENG-2329/make-sure-all-virtual-classes-in-c-code-base-have-virtual-destructor

Test Plan

Compile the app and make sure there are no more warnings related to missing virtual destructors

Diff Detail

Repository
rCOMM Comm
Branch
graszka22/ENG-2329
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Nov 15 2024, 1:26 PM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 15 2024, 1:26 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 15 2024, 1:34 PM
Harbormaster failed remote builds in B32690: Diff 45853!
Harbormaster completed remote builds in B32690: Diff 45853.Nov 15 2024, 1:52 PM
angelika requested review of this revision.Nov 15 2024, 1:52 PM
kamil accepted this revision.Nov 18 2024, 1:19 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
213

I would put this in line 193, where we have "shared" methods defined before methods defined via directives

This revision is now accepted and ready to land.Nov 18 2024, 1:19 AM
angelika updated this revision to Diff 45855.Nov 18 2024, 4:29 AM

Review comments

Harbormaster completed remote builds in B32691: Diff 45855.Nov 18 2024, 8:10 AM
Closed by commit rCOMM7a608523bf85: [native] Make sure all virtual classes in C++ code base have virtual destructor (authored by angelika). · Explain WhyNov 19 2024, 3:30 AM
This revision was automatically updated to reflect the committed changes.
angelika marked an inline comment as done.
angelika added a commit: rCOMM7a608523bf85: [native] Make sure all virtual classes in C++ code base have virtual destructor.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
1 line
NativeModules/
PersistentStorageUtilities/
MessageOperationsUtilities/
MessageSpecs/
2 lines
web/
shared-worker/
_generated/

Diff 45853

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/MessageSpec.h

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...