Paths

Table of Contentst

Differential D13981

[lib] Query for channel info in bulk whenever possible
ClosedPublic
Actions

Authored by ashoat on Wed, Nov 20, 6:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 1, 4:31 AM

	Unknown Object (File)
	Sun, Dec 1, 12:40 AM

	Unknown Object (File)
	Sat, Nov 30, 2:41 AM

	Unknown Object (File)
	Fri, Nov 29, 7:17 PM

	Unknown Object (File)
	Thu, Nov 28, 12:23 PM

	Unknown Object (File)
	Thu, Nov 28, 10:28 AM

	Unknown Object (File)
	Thu, Nov 28, 7:21 AM

	Unknown Object (File)
	Thu, Nov 28, 7:10 AM

View All 18 Files

Subscribers

Details

Reviewers

varun
will

Commits

rCOMM2be29ca39b8e: [lib] Query for channel info in bulk whenever possible

Summary

This helps address ENG-9930.

Depends on D13980

Test Plan

In combination with other diffs, tested that channel avatars still load on both web and native
Tested on both native and web by logging each NeynarClient query and seeing which ones get triggered

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Wed, Nov 20, 6:46 AM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Nov 20, 6:46 AM

ashoat added a child revision: D13982: [lib][native][web] Introduce FarcasterChannelPrefetchHandler.Wed, Nov 20, 6:47 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 20, 7:02 AM

Harbormaster failed remote builds in B32731: Diff 45905!

Lint fixes

ashoat published this revision for review.Wed, Nov 20, 7:15 AM

Harbormaster completed remote builds in B32734: Diff 45908.Wed, Nov 20, 8:08 AM

will accepted this revision.Wed, Nov 20, 2:28 PM

This revision is now accepted and ready to land.Wed, Nov 20, 2:28 PM

Closed by commit rCOMM2be29ca39b8e: [lib] Query for channel info in bulk whenever possible (authored by ashoat). · Explain WhyFri, Nov 22, 6:13 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2be29ca39b8e: [lib] Query for channel info in bulk whenever possible.

Revision Contents
Changeset List

Path

Size

lib/

utils/

120 lines

Diff 45905

lib/utils/fc-cache.js

Loading...