Paths

Table of Contentst

Differential D14095

[native_rust_library] make `start_backup_handler` thread-safe
ClosedPublic
Actions

Authored by kamil on Wed, Dec 11, 4:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 29, 9:02 AM

	Unknown Object (File)
	Sun, Dec 29, 2:40 AM

	Unknown Object (File)
	Fri, Dec 27, 1:25 PM

	Unknown Object (File)
	Thu, Dec 26, 8:25 AM

	Unknown Object (File)
	Wed, Dec 25, 7:55 AM

	Unknown Object (File)
	Sun, Dec 22, 9:51 AM

	Unknown Object (File)
	Sun, Dec 22, 3:23 AM

	Unknown Object (File)
	Sat, Dec 21, 9:06 PM

View All 15 Files

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM40b3cf167099: [native_rust_library] make `start_backup_handler` thread-safe

Summary

In the previous version, code was taking the Future out of the mutex-guarded Option, setting it to None initially. This means the mutex is shortly unlocked after assigning None (calling take), and technically creates a very small window for conditions to change and create new Future.

Test Plan

Login -> logout -> login = no issues about backup upload, user is not logged out automatically

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Wed, Dec 11, 4:33 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptWed, Dec 11, 4:33 AM

kamil added a child revision: D14096: [native] make sure `start_backup_handler` is called only once in `BackupHandler`.Wed, Dec 11, 4:34 AM

Harbormaster completed remote builds in B32992: Diff 46306.Wed, Dec 11, 4:51 AM

kamil published this revision for review.Wed, Dec 11, 5:05 AM

bartek accepted this revision.Wed, Dec 11, 10:40 PM

This revision is now accepted and ready to land.Wed, Dec 11, 10:40 PM

Closed by commit rCOMM40b3cf167099: [native_rust_library] make `start_backup_handler` thread-safe (authored by kamil). · Explain WhyTue, Dec 17, 4:27 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM40b3cf167099: [native_rust_library] make `start_backup_handler` thread-safe.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

backup/

upload_handler.rs

12 lines

Diff 46306

native/native_rust_library/src/backup/upload_handler.rs

Loading...