[CommCoreModule] avoid triggering backup upload on SQLite changes
ClosedPublic
Actions

Authored by kamil on Wed, Dec 11, 4:36 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM271fb24f3a47: [CommCoreModule] avoid triggering backup upload on SQLite changes

Summary

ENG-10001.

This is triggered on any DB write operation, we can avoid it and bring it back when having User Data.

Adding this to ENG-9921

Depends on D14096

Test Plan

Made some changes in the app - the backup handler is not triggered.

Diff Detail

Repository

rCOMM Comm

Branch

backup-fixes

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Wed, Dec 11, 4:36 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptWed, Dec 11, 4:36 AM

kamil edited the test plan for this revision. (Show Details)Wed, Dec 11, 4:36 AM

Harbormaster completed remote builds in B32994: Diff 46308.Wed, Dec 11, 5:04 AM

kamil published this revision for review.Wed, Dec 11, 5:05 AM

bartek accepted this revision.Thu, Dec 12, 12:34 AM

This revision is now accepted and ready to land.Thu, Dec 12, 12:34 AM

Closed by commit rCOMM271fb24f3a47: [CommCoreModule] avoid triggering backup upload on SQLite changes (authored by kamil). · Explain WhyTue, Dec 17, 4:27 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM271fb24f3a47: [CommCoreModule] avoid triggering backup upload on SQLite changes.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

4 lines

PersistentStorageUtilities/

DataStores/

BaseDataStore.h

2 lines

Diff 46308

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp