Page MenuHomePhabricator
Differential D14147

[native][web] Merge logout buttons for old and new flows
ClosedPublic
Actions

Authored by bartek on Thu, Dec 12, 7:22 AM.
Tags
None
Referenced Files
F3517158: D14147.diff
Sun, Dec 22, 4:28 PM
F3516716: D14147.id46382.diff
Sun, Dec 22, 3:13 PM
F3515945: D14147.id46497.diff
Sun, Dec 22, 11:13 AM
F3515910: D14147.id46385.diff
Sun, Dec 22, 11:01 AM
Unknown Object (File)
Sat, Dec 21, 4:25 PM
Unknown Object (File)
Fri, Dec 20, 4:20 PM
Unknown Object (File)
Fri, Dec 20, 11:56 AM
Unknown Object (File)
Fri, Dec 20, 11:16 AM
View All 20 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM0f7e12dce745: [native][web] Merge logout buttons for old and new flows
Summary

Address ENG-9688.

  • Removed the experimental buttons for new logout flows
  • Main logout button behavior depends on usingRestoreFlow:
    • legacy logout (current behavior) if false
    • Primary/secondary logout if true

Depends on D14146

Test Plan

Changed the flag true/false and pressed logout button. Made sure correct procedure is executed

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Thu, Dec 12, 7:22 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptThu, Dec 12, 7:22 AM
Harbormaster failed remote builds in B33059: Diff 46380!Thu, Dec 12, 7:48 AM
bartek updated this revision to Diff 46383.Thu, Dec 12, 7:53 AM

Rebase

Harbormaster completed remote builds in B33062: Diff 46383.Thu, Dec 12, 8:12 AM
bartek published this revision for review.Thu, Dec 12, 11:28 PM
kamil accepted this revision.Mon, Dec 16, 6:02 AM
kamil added inline comments.
native/profile/profile-screen.react.js
361–364

are you sure we don't want to show Alerts that are implemented below and early return?

This revision is now accepted and ready to land.Mon, Dec 16, 6:02 AM
bartek added inline comments.Mon, Dec 16, 6:45 AM
native/profile/profile-screen.react.js
361–364

Yes. onPressNewLogout() has its own alerts

Closed by commit rCOMM0f7e12dce745: [native][web] Merge logout buttons for old and new flows (authored by bartek). · Explain WhyMon, Dec 16, 6:48 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM0f7e12dce745: [native][web] Merge logout buttons for old and new flows.

Revision Contents
Changeset List

PathSize
native/
profile/
19 lines
web/
settings/
37 lines

Diff 46383

View Options

native/profile/profile-screen.react.js

Loading...
View Options

web/settings/account-settings.react.js

Loading...