Page MenuHomePhabricator
Differential D14310

[native] Remove leftover Reanimated v1 code in FullScreenViewModal
ClosedPublic
Actions

Authored by angelika on Feb 6 2025, 5:42 PM.
Tags
None
Referenced Files
F6268183: D14310.id47212.diff
Fri, Apr 25, 11:31 AM
Unknown Object (File)
Mon, Apr 21, 12:25 PM
Unknown Object (File)
Mon, Apr 21, 12:21 PM
Unknown Object (File)
Mon, Apr 21, 11:57 AM
Unknown Object (File)
Mon, Apr 21, 11:42 AM
Unknown Object (File)
Mon, Apr 21, 11:10 AM
Unknown Object (File)
Fri, Apr 18, 9:08 PM
Unknown Object (File)
Fri, Apr 18, 11:00 AM
View All 91 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMM43c03694bf15: [native] Remove leftover Reanimated v1 code in FullScreenViewModal
Summary

https://linear.app/comm/issue/ENG-8150/convert-fullscreenviewmodal-to-reanimated-2-syntax

After migrating the last function from updates array, there is a lot of code left to be removed. For the readability of the diffs I removed it in one diff.
CI should pass now, the component still needs to be migrated completely to work.

Depends on D14309

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Feb 6 2025, 5:42 PM
angelika held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 6 2025, 5:42 PM
angelika added a child revision: D14311: [native] Migrate updateDimensions method in FullScreenViewModal to functional component.Feb 6 2025, 5:44 PM
Harbormaster completed remote builds in B33425: Diff 46954.Feb 6 2025, 6:59 PM
angelika edited the summary of this revision. (Show Details)Feb 10 2025, 1:04 AM
angelika updated this revision to Diff 47088.Feb 12 2025, 8:53 PM

Rebase & bugfixes

angelika published this revision for review.Feb 12 2025, 9:10 PM
Harbormaster completed remote builds in B33504: Diff 47088.Feb 12 2025, 11:00 PM
tomek accepted this revision.Feb 17 2025, 4:02 AM
This revision is now accepted and ready to land.Feb 17 2025, 4:02 AM
angelika updated this revision to Diff 47192.Feb 20 2025, 2:15 PM

Rebase & bugfixes

angelika updated this revision to Diff 47204.Feb 21 2025, 8:08 PM

Rebase

Harbormaster failed remote builds in B33584: Diff 47204!Feb 21 2025, 8:26 PM
angelika updated this revision to Diff 47210.Feb 21 2025, 10:14 PM

Fix rebase

Harbormaster completed remote builds in B33590: Diff 47210.Feb 21 2025, 10:48 PM
angelika updated this revision to Diff 47226.Feb 24 2025, 3:53 AM

Rebase

Harbormaster completed remote builds in B33606: Diff 47226.Feb 24 2025, 6:44 AM
Closed by commit rCOMM43c03694bf15: [native] Remove leftover Reanimated v1 code in FullScreenViewModal (authored by angelika). · Explain WhyFeb 25 2025, 2:48 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM43c03694bf15: [native] Remove leftover Reanimated v1 code in FullScreenViewModal.

Revision Contents
Changeset List

PathSize
native/
components/
217 lines

Diff 47088

View Options

native/components/full-screen-view-modal.react.js

Loading...