Paths

Table of Contentst

Differential D14299

[native] Migrate state in FullScreenViewModal to functional component
ClosedPublic
Actions

Authored by angelika on Feb 7 2025, 1:02 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM5205769762e3: [native] Migrate state in FullScreenViewModal to functional component

Summary

https://linear.app/comm/issue/ENG-8150/convert-fullscreenviewmodal-to-reanimated-2-syntax

Depends on D14298

Test Plan

Verify close and action buttons work correctly

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Feb 7 2025, 1:02 AM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 7 2025, 1:02 AM

angelika added a child revision: D14300: [native] Migrate gestures to react-native-gesture-handler v2 API in FullScreenViewModal.Feb 7 2025, 1:05 AM

Harbormaster completed remote builds in B33414: Diff 46943.Feb 7 2025, 1:21 AM

Rebase & bugfixes

angelika published this revision for review.Feb 13 2025, 5:04 AM

Harbormaster completed remote builds in B33493: Diff 47077.Feb 13 2025, 5:12 AM

tomek accepted this revision.Feb 13 2025, 6:29 PM

tomek added inline comments.

native/components/full-screen-view-modal.react.js
1244 ↗	(On Diff #47077)	We should prefer `Array` type

This revision is now accepted and ready to land.Feb 13 2025, 6:29 PM

Rebase & bugfixes

angelika added inline comments.Feb 20 2025, 10:39 PM

native/components/full-screen-view-modal.react.js
1244 ↗	(On Diff #47077)	This was just copied from the original code and the `[number]` argument will be replaced with `number` argument in https://phab.comm.dev/D14304 anyway

Rebase

Harbormaster completed remote builds in B33595: Diff 47215.Feb 24 2025, 12:19 PM

Closed by commit rCOMM5205769762e3: [native] Migrate state in FullScreenViewModal to functional component. · Explain WhyFeb 25 2025, 10:48 AM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM5205769762e3: [native] Migrate state in FullScreenViewModal to functional component.

Revision Contents
Changeset List

Path

Size

native/

components/

full-screen-view-modal.react.js

61 lines

Diff 47215

native/components/full-screen-view-modal.react.js

Loading...