Paths

Table of Contentst

Differential D14620

[native] Add c++ util to parse ed25519 key from JSON blob
ClosedPublic
Actions

Authored by bartek on Apr 29 2025, 1:34 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

kamil
tomek

Commits

rCOMMa6095a57d06a: [native] Add c++ util to parse ed25519 key from JSON blob

Summary

Added an utility function that takes identity keys JSON blob from Olm account and extracts ed25519 signing public key.
The function will be used for prekey verification.
Code was inspired by the CommCoreModule::getUserPublicKey() (however it was not possible to easily deduplicate code, that function does other stuff too).

Depends on D14619

Test Plan

iOS and Android build. The function is used and tested in the next diff.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 29 2025, 1:34 PM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 29 2025, 1:34 PM

bartek added a child revision: D14621: [native] Verify prekey signatures when rotating.Apr 29 2025, 1:39 PM

Rebase

Harbormaster failed remote builds in B34045: Diff 47892!Apr 29 2025, 2:06 PM

Harbormaster completed remote builds in B34048: Diff 47895.Apr 29 2025, 2:30 PM

bartek published this revision for review.Apr 29 2025, 2:31 PM

kamil accepted this revision.Apr 29 2025, 2:40 PM

This revision is now accepted and ready to land.Apr 29 2025, 2:40 PM

Closed by commit rCOMMa6095a57d06a: [native] Add c++ util to parse ed25519 key from JSON blob. · Explain WhyApr 29 2025, 2:49 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMa6095a57d06a: [native] Add c++ util to parse ed25519 key from JSON blob.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

Tools/

8 lines

21 lines

Diff 47892

native/cpp/CommonCpp/Tools/OlmUtils.h

Loading...

native/cpp/CommonCpp/Tools/OlmUtils.cpp

Loading...