Paths

Table of Contentst

Differential D14667

[web] deprecate using `*ThreadWeb` methods and use shared implementation with native
ClosedPublic
Actions

Authored by kamil on May 8 2025, 3:56 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMMd92c22b90e97: [web] deprecate using `*ThreadWeb` methods and use shared implementation with…

Summary

Before C++17 we had to use pointers to simulate nullable values. After updating and implementing std::optional marshalling in D12736, we can use a more appropriate std::optional (C++) <-> undefined (JS) conversion and avoid implementation differences between web and native.

Depends on D14666

Test Plan

cd web & yarn jest

Diff Detail

Repository

Branch

optional-handling

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.May 8 2025, 3:56 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 8 2025, 3:56 PM

kamil added inline comments.May 8 2025, 3:58 PM

web/shared-worker/types/entities.js
17	Unfortunately, we still can't use `ClientDBThreadInfo` because of `bigint` type which is `string` in `ClientDBThreadInfo`

kamil added a child revision: D14668: [web][native] convert `MessageEntity` to struct.May 8 2025, 4:08 PM

Harbormaster failed remote builds in B34113: Diff 47986!May 8 2025, 4:14 PM

rebase

Harbormaster completed remote builds in B34119: Diff 47992.May 8 2025, 5:59 PM

kamil published this revision for review.May 9 2025, 10:03 AM

bartek accepted this revision.May 13 2025, 6:43 AM

This revision is now accepted and ready to land.May 13 2025, 6:43 AM

Closed by commit rCOMMd92c22b90e97: [web] deprecate using `*ThreadWeb` methods and use shared implementation with…. · Explain WhyMay 13 2025, 12:54 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMd92c22b90e97: [web] deprecate using `*ThreadWeb` methods and use shared implementation with….

Revision Contents
Changeset List

Path

Size

web/

cpp/

SQLiteQueryExecutorBindings.cpp

40 lines

shared-worker/

_generated/

comm-query-executor.js

comm_query_executor.wasm

queries/

messages-and-media-queries.test.js

41 lines

threads-queries.test.js

67 lines

types/

60 lines

sqlite-query-executor.js

4 lines

worker/

process-operations.js

4 lines

Diff 47986

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...

web/shared-worker/_generated/comm-query-executor.js

Loading...

web/shared-worker/_generated/comm_query_executor.wasm

Loading...

web/shared-worker/queries/messages-and-media-queries.test.js

Loading...

web/shared-worker/queries/threads-queries.test.js

Loading...

web/shared-worker/types/entities.js

Loading...

web/shared-worker/types/sqlite-query-executor.js

Loading...

web/shared-worker/worker/process-operations.js

Loading...