Details

Reviewers

bartek
tomek

Commits

rCOMM504ed5d3d8a7: [SQLite] remove web-specific code

Summary

ENG-5719.

This code can now be removed. Currently we reuse a lot of the code which makes it more readable. It also decreased .wasm file size by ~35kb

Depends on D14670

Test Plan

cd web & yarn jest

Diff Detail

Repository

rCOMM Comm

Branch

optional-handling

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.May 8 2025, 4:21 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 8 2025, 4:21 PM

Harbormaster failed remote builds in B34117: Diff 47990!May 8 2025, 4:51 PM

rebase

Harbormaster completed remote builds in B34124: Diff 47997.May 8 2025, 7:22 PM

Harbormaster completed remote builds in B34123: Diff 47996.May 8 2025, 7:26 PM

kamil published this revision for review.May 9 2025, 10:05 AM

kamil edited the summary of this revision. (Show Details)

It's always satisfying to see this much of code being removed

This revision is now accepted and ready to land.May 13 2025, 6:57 AM

rebase before landing

Harbormaster completed remote builds in B34162: Diff 48061.May 13 2025, 11:37 AM

I did more testing with test messages, media messages, threads, and message search on both web and native

Closed by commit rCOMM504ed5d3d8a7: [SQLite] remove web-specific code. · Explain WhyMay 13 2025, 12:54 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM504ed5d3d8a7: [SQLite] remove web-specific code.

[SQLite] remove web-specific code
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 47997

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/Message.h

native/cpp/CommonCpp/DatabaseManagers/entities/Nullable.h

native/cpp/CommonCpp/DatabaseManagers/entities/Thread.h

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/types/entities.js

[SQLite] remove web-specific codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47997

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/Message.h

native/cpp/CommonCpp/DatabaseManagers/entities/Nullable.h

native/cpp/CommonCpp/DatabaseManagers/entities/Thread.h

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/types/entities.js

[SQLite] remove web-specific code
ClosedPublic
Actions

Revision Contents
Changeset List