Differential D15309

[lib] Improve Farcaster sync loading state
ClosedPublic
Actions

Authored by tomek on Sep 9 2025, 2:07 PM.

Tags

None

Referenced Files

	F12989132: Screen Recording 2025-09-09 at 15.58.23.mov
	Sep 9 2025, 2:08 PM

	F12989129: IMG_6406.PNG
	Sep 9 2025, 2:08 PM

Subscribers

Details

Reviewers

kamil
bartek

Commits

rCOMMbd8d21a5bc88: [lib] Improve Farcaster sync loading state

Summary

The sync may take a lot of time for power users, so I checked what can be done in an hour with the AI in order to make the progress more predictable.

IMG_6406.PNG (2×1 px, 158 KB)

Depends on D15306

Test Plan

Checked if the loading state is displayed correctly on native and web.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Sep 9 2025, 2:07 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 9 2025, 2:07 PM

tomek edited the summary of this revision. (Show Details)Sep 9 2025, 2:08 PM

Harbormaster completed remote builds in B35659: Diff 50206.Sep 9 2025, 2:27 PM

tomek requested review of this revision.Sep 9 2025, 2:27 PM

tomek added a child revision: D15310: [lib] Avoid continous preview fetching.Sep 9 2025, 5:30 PM

Remove console.log

Harbormaster failed remote builds in B35661: Diff 50209!Sep 10 2025, 10:56 AM

Harbormaster completed remote builds in B35661: Diff 50209.Sep 10 2025, 11:47 AM

kamil accepted this revision.Sep 11 2025, 10:06 AM

kamil added inline comments.

lib/shared/farcaster/farcaster-hooks.js
553–559 ↗	(On Diff #50209)	can be shortened
web/farcaster/farcaster-sync-loading-screen.react.js
26 ↗	(On Diff #50209)	I would add a division by zero check just in case

This revision is now accepted and ready to land.Sep 11 2025, 10:06 AM

Use shorthand and check if we're not dividing by zero

Harbormaster failed remote builds in B35688: Diff 50241!Sep 11 2025, 1:02 PM

This revision was landed with ongoing or failed builds.Sep 11 2025, 2:00 PM

Closed by commit rCOMMbd8d21a5bc88: [lib] Improve Farcaster sync loading state. · Explain Why

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMbd8d21a5bc88: [lib] Improve Farcaster sync loading state.

Revision Contents
Changeset List

Path

Size

lib/

shared/

farcaster/

farcaster-hooks.js

65 lines

native/

farcaster/

farcaster-sync-loading-screen.react.js

40 lines

web/

farcaster/

farcaster-sync-loading-screen.react.js

25 lines

Diff 50241

lib/shared/farcaster/farcaster-hooks.js

Loading...

native/farcaster/farcaster-sync-loading-screen.react.js

Loading...

web/farcaster/farcaster-sync-loading-screen.react.js

Loading...