NA
Details
Diff Detail
- Repository
- rCOMM Comm
- Branch
- feb24 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Could you add a screen shot? Does this code even do anything? Maybe it should be removed?
Could you add a screen shot? Does this code even do anything? Maybe it should be removed?
There's a <header> with className header in both splash.react.js and app.react.js.. which corresponds to the header:
The typo was "covered up" by the div.main-header within the header which has its background set to var(--bg).
The typo was mistakenly introduced in this commit: https://phabricator.ashoat.com/D2928
@atul, please do not land diffs that are not in an accepted state. If you do find yourself needing to do that, please add a comment to the diff explaining why you're doing it. Your current pattern is normalizing this behavior on the team and I would like us to avoid normalizing it.