[web] Remove extraneous `sidebarExistsOrCanBeCreated` prop in `MessageActionButtons`
ClosedPublic
Actions

Authored by atul on Feb 28 2022, 3:55 PM.

Details

Reviewers

• jacek
tomek
varun
• benschac

Commits

rCOMM93d079ef9a8c: [web] Remove extraneous `sidebarExistsOrCanBeCreated` prop in…

Summary

Can use useSidebarExistsOrCanBeCreated hook directly instead of "drilling" it in.

Test Plan

Close reading, things seem to continue working as expected

Diff Detail

Repository

rCOMM Comm

Branch

feb24 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 28 2022, 3:55 PM

Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptFeb 28 2022, 3:55 PM

Harbormaster completed remote builds in B7079: Diff 9970.Feb 28 2022, 3:59 PM

atul requested review of this revision.Feb 28 2022, 3:59 PM

tomek accepted this revision.Mar 1 2022, 3:34 AM

This revision is now accepted and ready to land.Mar 1 2022, 3:34 AM

atul mentioned this in D3306: [web] Move `replyButton` from `ComposedMessage` to `MessageActionButtons`.Mar 7 2022, 6:49 AM

rebase

Harbormaster completed remote builds in B7185: Diff 10114.Mar 7 2022, 9:48 AM

Closed by commit rCOMM93d079ef9a8c: [web] Remove extraneous `sidebarExistsOrCanBeCreated` prop in… (authored by atul). · Explain WhyMar 8 2022, 11:29 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM93d079ef9a8c: [web] Remove extraneous `sidebarExistsOrCanBeCreated` prop in….

Revision Contents
Changeset List

Path

Size

web/

chat/

composed-message.react.js

1 line

message-action-buttons.js

8 lines

Diff 9970

View Options

web/chat/composed-message.react.js