Page MenuHomePhabricator
Differential D3311

[web] Remove extraneous `containerPosition` prop from `MessageActionButtons`
ClosedPublic
Actions

Authored by atul on Feb 28 2022, 6:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 1:10 PM
Unknown Object (File)
Tue, Apr 15, 8:34 PM
Unknown Object (File)
Tue, Apr 8, 7:10 AM
Unknown Object (File)
Tue, Apr 8, 6:20 AM
Unknown Object (File)
Tue, Apr 1, 6:06 AM
Unknown Object (File)
Mon, Mar 31, 8:52 PM
Unknown Object (File)
Mar 6 2025, 8:53 PM
Unknown Object (File)
Feb 20 2025, 9:17 PM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
varun
• benschac
Commits
rCOMM3f7eaeea385d: [web] Remove extraneous `containerPosition` prop from `MessageActionButtons`
Summary

We can get containerPosition from mouseOverMessagePosition instead of passing it in directly as a prop

Test Plan

NA, flow

Diff Detail

Repository
rCOMM Comm
Branch
feb24 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 28 2022, 6:27 PM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptFeb 28 2022, 6:27 PM
Harbormaster completed remote builds in B7080: Diff 9971.Feb 28 2022, 6:32 PM
atul requested review of this revision.Feb 28 2022, 6:32 PM
atul updated this revision to Diff 9973.Feb 28 2022, 6:35 PM

rebase

Harbormaster completed remote builds in B7082: Diff 9973.Feb 28 2022, 6:42 PM
tomek accepted this revision.Mar 1 2022, 3:36 AM
This revision is now accepted and ready to land.Mar 1 2022, 3:36 AM
atul mentioned this in D3306: [web] Move `replyButton` from `ComposedMessage` to `MessageActionButtons`.Mar 7 2022, 6:49 AM
atul updated this revision to Diff 10115.Mar 7 2022, 9:44 AM

rebase

Harbormaster completed remote builds in B7186: Diff 10115.Mar 7 2022, 9:52 AM
Closed by commit rCOMM3f7eaeea385d: [web] Remove extraneous `containerPosition` prop from `MessageActionButtons` (authored by atul). · Explain WhyMar 8 2022, 11:35 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM3f7eaeea385d: [web] Remove extraneous `containerPosition` prop from `MessageActionButtons`.

Revision Contents
Changeset List

Diff 9973

View Options

web/chat/composed-message.react.js

Show First 20 Lines • Show All 184 Lines • ▼ Show 20 Lines return (
<LeftLayoutAside setModal={this.setModal} /> <LeftLayoutAside setModal={this.setModal} />
</div> </div>
); );
} }
setModal = (modal: ?React.Node) => { setModal = (modal: ?React.Node) => {
this.setState({ modal }); this.setState({ modal });
}; };
clearModal() {
this.setModal(null);
}
} }
const fetchEntriesLoadingStatusSelector = createLoadingStatusSelector( const fetchEntriesLoadingStatusSelector = createLoadingStatusSelector(
fetchEntriesActionTypes, fetchEntriesActionTypes,
); );
const updateCalendarQueryLoadingStatusSelector = createLoadingStatusSelector( const updateCalendarQueryLoadingStatusSelector = createLoadingStatusSelector(
updateCalendarQueryActionTypes, updateCalendarQueryActionTypes,
); );
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines
View Options

web/chat/message-action-buttons.js

Show First 20 Lines • Show All 184 Lines • ▼ Show 20 Lines return (
<LeftLayoutAside setModal={this.setModal} /> <LeftLayoutAside setModal={this.setModal} />
</div> </div>
); );
} }
setModal = (modal: ?React.Node) => { setModal = (modal: ?React.Node) => {
this.setState({ modal }); this.setState({ modal });
}; };
clearModal() {
this.setModal(null);
}
} }
const fetchEntriesLoadingStatusSelector = createLoadingStatusSelector( const fetchEntriesLoadingStatusSelector = createLoadingStatusSelector(
fetchEntriesActionTypes, fetchEntriesActionTypes,
); );
const updateCalendarQueryLoadingStatusSelector = createLoadingStatusSelector( const updateCalendarQueryLoadingStatusSelector = createLoadingStatusSelector(
updateCalendarQueryActionTypes, updateCalendarQueryActionTypes,
); );
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines
View Options

web/chat/robotext-message.react.js

Show First 20 Lines • Show All 184 Lines • ▼ Show 20 Lines return (
<LeftLayoutAside setModal={this.setModal} /> <LeftLayoutAside setModal={this.setModal} />
</div> </div>
); );
} }
setModal = (modal: ?React.Node) => { setModal = (modal: ?React.Node) => {
this.setState({ modal }); this.setState({ modal });
}; };
clearModal() {
this.setModal(null);
}
} }
const fetchEntriesLoadingStatusSelector = createLoadingStatusSelector( const fetchEntriesLoadingStatusSelector = createLoadingStatusSelector(
fetchEntriesActionTypes, fetchEntriesActionTypes,
); );
const updateCalendarQueryLoadingStatusSelector = createLoadingStatusSelector( const updateCalendarQueryLoadingStatusSelector = createLoadingStatusSelector(
updateCalendarQueryActionTypes, updateCalendarQueryActionTypes,
); );
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines