Page MenuHomePhabricator
Feed Advanced Search

Mar 23 2023

jon added a comment to D7130: [Identity] Add client device service to identity service.

feedback

Mar 23 2023, 7:41 AM
jon updated the diff for D7130: [Identity] Add client device service to identity service.

ran -> run

Mar 23 2023, 7:40 AM

Mar 22 2023

jon updated the diff for D7130: [Identity] Add client device service to identity service.

rebase on master

Mar 22 2023, 11:43 AM
jon updated the diff for D7116: [Comm-opaque2] Change project name to avoid name clash.

Rebase on master

Mar 22 2023, 11:43 AM
jon added a comment to D7130: [Identity] Add client device service to identity service.

Address feedback

Mar 22 2023, 11:42 AM
jon updated the diff for D7130: [Identity] Add client device service to identity service.

svc -> keyserver_service

Mar 22 2023, 11:42 AM
jon added inline comments to D7130: [Identity] Add client device service to identity service.
Mar 22 2023, 10:48 AM
jon requested review of D7130: [Identity] Add client device service to identity service.
Mar 22 2023, 9:53 AM
jon updated the diff for D7115: [Identity] Update X3DH protobuf to differiente key requests.

Move prekey information to top-level message

Mar 22 2023, 7:34 AM

Mar 21 2023

jon requested review of D7116: [Comm-opaque2] Change project name to avoid name clash.
Mar 21 2023, 12:51 PM
jon added inline comments to D7115: [Identity] Update X3DH protobuf to differiente key requests.
Mar 21 2023, 12:23 PM
jon updated the diff for D7115: [Identity] Update X3DH protobuf to differiente key requests.

Expand comment on Sender / Receiver RPCs

Mar 21 2023, 12:21 PM
jon updated the diff for D7115: [Identity] Update X3DH protobuf to differiente key requests.

Use Sender / Receiver as X3DH roles

Mar 21 2023, 12:19 PM
jon resigned from D7105: Build files set-up for Android 13.

not very well versed in gradle, but please add me to cmake related stuff in the future :)

Mar 21 2023, 10:02 AM

Mar 20 2023

jon updated the diff for D7115: [Identity] Update X3DH protobuf to differiente key requests.

Fix what information is being requested by whom

Mar 20 2023, 9:59 PM
jon requested review of D7115: [Identity] Update X3DH protobuf to differiente key requests.
Mar 20 2023, 9:53 PM
jon added inline comments to D7113: [native] RustPromiseManager.
Mar 20 2023, 9:44 PM
jon closed D7087: [Comm-opaque2] Add wasm build to client.
Mar 20 2023, 8:50 PM
jon committed rCOMMfa13b21baf73: [Comm-opaque2] Add wasm build to client (authored by jon).
[Comm-opaque2] Add wasm build to client
Mar 20 2023, 8:50 PM
jon added a comment to D7087: [Comm-opaque2] Add wasm build to client.

feedback

Mar 20 2023, 3:22 PM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

typo

Mar 20 2023, 3:17 PM
jon added inline comments to D7087: [Comm-opaque2] Add wasm build to client.
Mar 20 2023, 10:03 AM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

Address Feedback

Mar 20 2023, 10:03 AM
jon closed D6722: [Android] Reference Tools by CMake project.
Mar 20 2023, 7:45 AM
jon committed rCOMM6f883b5879f0: [Android] Reference Tools by CMake project (authored by jon).
[Android] Reference Tools by CMake project
Mar 20 2023, 7:45 AM

Mar 17 2023

jon closed D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 17 2023, 3:41 PM
jon committed rCOMM8751e77ed757: [comm-opaque] Create opaque 2.0 facade for usage in Comm (authored by jon).
[comm-opaque] Create opaque 2.0 facade for usage in Comm
Mar 17 2023, 3:41 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 17 2023, 3:38 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

rlib -> lib

Mar 17 2023, 2:38 PM

Mar 16 2023

jon added a comment to D7087: [Comm-opaque2] Add wasm build to client.

This currently produces the outpus:

$ du -hd0 --apparent-size pkg/*
715	pkg/comm_opaque.d.ts
160	pkg/comm_opaque.js
14K	pkg/comm_opaque_bg.js
142K	pkg/comm_opaque_bg.wasm
1005	pkg/comm_opaque_bg.wasm.d.ts
249	pkg/package.json
Mar 16 2023, 5:04 PM
jon added a comment to D7087: [Comm-opaque2] Add wasm build to client.

Add @ashoat because addtion of wasm-pack utility, and new usage of wasm_bindgen crate

Mar 16 2023, 5:02 PM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

Add back rlib for in-repo usage

Mar 16 2023, 5:01 PM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

Add wasm-pack to this diff

Mar 16 2023, 5:00 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Move wasm-pack to wasm diff

Mar 16 2023, 4:59 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 4:56 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Address feedback

Mar 16 2023, 4:56 PM
jon requested review of D7087: [Comm-opaque2] Add wasm build to client.
Mar 16 2023, 4:45 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 11:34 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Prune stale dependencies

Mar 16 2023, 10:30 AM
jon retitled D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm from [comm-opaque] Create opaque facade for usage in Comm to [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 9:41 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Also assert that session_key was set in test

Mar 16 2023, 9:37 AM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 9:31 AM
jon requested review of D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 9:22 AM
jon planned changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 9:16 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Remove sever_setup from constructors

Mar 16 2023, 9:15 AM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Use opaque 2.0, remove server setup

Mar 16 2023, 9:12 AM

Mar 15 2023

jon planned changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

i'm a little confused why we're moving config.rs and constants.rs into this cargo project. they seem pretty specific to the identity service.

Mar 15 2023, 9:04 PM

Mar 14 2023

jon updated the test plan for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 14 2023, 8:15 PM
jon added a comment to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

I might move this code into shared/comm-opaque2, so that we can retain the opaque 1.2 Cipher definition as it is now and avoid having to tackle the migration immediately. Once we trigger the migration, we can just replace the 1.2 code once we are ready to migrate over to opaque 2.0.

Mar 14 2023, 8:12 PM
jon closed D7062: [Identity] Add X3DH RPCs.
Mar 14 2023, 7:59 PM
jon committed rCOMM265abf6197f0: [Identity] Add X3DH RPCs (authored by jon).
[Identity] Add X3DH RPCs
Mar 14 2023, 7:59 PM
jon closed D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 14 2023, 7:59 PM
jon committed rCOMM3dc6c22047be: [Identity] Add client <-> identity protobuf defintions (authored by jon).
[Identity] Add client <-> identity protobuf defintions
Mar 14 2023, 7:59 PM
jon added a comment to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Not going tackle updating to 2.0 in this diff, as all downstream usages of comm-opaque::Cipher (which is currently the entire code base) will need to be updated as well.

Mar 14 2023, 2:46 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Expose facade as OOP

Mar 14 2023, 2:40 PM
jon added a comment to D7003: [Identity] Add client <-> identity protobuf defintions.

Address feedback

Mar 14 2023, 11:29 AM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

Remove stream from update RPC, remove deviceEd25519 fields

Mar 14 2023, 11:29 AM
jon added inline comments to D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 14 2023, 9:54 AM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

opaqueServerResponse -> opaqueLoginResponse

Mar 14 2023, 9:39 AM
jon abandoned D7020: [comm-opaque] Add dependencies for client and server logic.

Going to merge into D7022

Mar 14 2023, 9:33 AM
jon updated the diff for D6722: [Android] Reference Tools by CMake project.

Rebase on master

Mar 14 2023, 9:31 AM
jon updated the diff for D7062: [Identity] Add X3DH RPCs.

Have prekey refresh only pass prekeys and not onetime keys

Mar 14 2023, 9:26 AM
jon added inline comments to D7062: [Identity] Add X3DH RPCs.
Mar 14 2023, 9:26 AM
jon added inline comments to D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none".
Mar 14 2023, 9:20 AM

Mar 13 2023

jon updated the diff for D7062: [Identity] Add X3DH RPCs.

Use username or wallet ID for looking up keyserver info

Mar 13 2023, 2:54 PM
jon updated the diff for D7062: [Identity] Add X3DH RPCs.

Use userID to find KeyserverInfo

Mar 13 2023, 1:14 PM
jon added a comment to D7003: [Identity] Add client <-> identity protobuf defintions.

For now, I renamed them all deviceEd25519PublicKey as I think that was the goal initially

Mar 13 2023, 12:35 PM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

signingPublicKey -> deviceEd25519PublicKey

Mar 13 2023, 12:34 PM
jon added inline comments to D7062: [Identity] Add X3DH RPCs.
Mar 13 2023, 12:28 PM
jon updated the diff for D7062: [Identity] Add X3DH RPCs.

Fix refreshPreKeys message. response -> upload

Mar 13 2023, 12:28 PM
jon added inline comments to D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 13 2023, 11:59 AM
jon requested review of D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 13 2023, 11:55 AM
jon added inline comments to D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 13 2023, 11:55 AM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

Split opaque RPCs into two unary RPCs

Mar 13 2023, 11:48 AM
jon updated the diff for D7062: [Identity] Add X3DH RPCs.

Correct KeyserverKeysResponse structure

Mar 13 2023, 11:26 AM
jon requested review of D7062: [Identity] Add X3DH RPCs.
Mar 13 2023, 10:43 AM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

Limit diff to just account actions

Mar 13 2023, 10:25 AM

Mar 12 2023

jon added inline comments to D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none".
Mar 12 2023, 8:05 PM

Mar 10 2023

jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 10 2023, 12:56 PM
jon added a comment to D7020: [comm-opaque] Add dependencies for client and server logic.

i don't love adding the dependencies in a separate diff, would like to see them added when they're actually being used

Mar 10 2023, 10:42 AM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 10 2023, 10:26 AM
jon planned changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Going to go to a more OOP-like approach instead of some "static methods". Following https://github.com/marucjmar/opaque-wasm as an example of more ergonomic JS bindings.

Mar 10 2023, 10:22 AM
jon closed D7028: [Identity] Change default port to 50054 to avoid port collision.
Mar 10 2023, 9:22 AM
jon committed rCOMMabfa7ff6229f: [Identity] Change default port to 50054 to avoid port collision (authored by jon).
[Identity] Change default port to 50054 to avoid port collision
Mar 10 2023, 9:22 AM
jon updated the diff for D7028: [Identity] Change default port to 50054 to avoid port collision.

Rebase on master

Mar 10 2023, 9:03 AM
jon added inline comments to D7028: [Identity] Change default port to 50054 to avoid port collision.
Mar 10 2023, 9:00 AM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

Address feedback:

  • clarify service comment
  • Make LoginPasswordUser into stream, and finalize OPAQUE
  • Remove GetUserID (at least for now, until we have a use case)
  • signingPublicKey -> deviceEd25519PublicKey
  • align opaque message with opaque_ke terms
Mar 10 2023, 8:59 AM
jon added inline comments to D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 10 2023, 8:59 AM
jon added a comment to D7031: [CI] Fix macos buildkite ci.

looks fine to me, not going to accept so that atul can take a look as he's probably more familar with mac workflow.

Mar 10 2023, 8:28 AM
jon updated the diff for D7028: [Identity] Change default port to 50054 to avoid port collision.

grpc -> gRPC

Mar 10 2023, 8:27 AM

Mar 9 2023

jon requested review of D7028: [Identity] Change default port to 50054 to avoid port collision.
Mar 9 2023, 4:16 PM
jon closed D7001: [Identity] Rename IdentityService service to IdentityKeyserverService.
Mar 9 2023, 3:27 PM
jon committed rCOMM538ca1cc8b28: [Identity] Rename IdentityService service to IdentityKeyserverService (authored by jon).
[Identity] Rename IdentityService service to IdentityKeyserverService
Mar 9 2023, 3:27 PM
jon updated the diff for D7003: [Identity] Add client <-> identity protobuf defintions.

UpdateUser -> UpdateUserPassword
Add comment on rpcs
Use a single "Empty" message instead of rpc specific versions

Mar 9 2023, 3:21 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 9 2023, 11:53 AM
jon added inline comments to D7020: [comm-opaque] Add dependencies for client and server logic.
Mar 9 2023, 11:32 AM
jon requested review of D7020: [comm-opaque] Add dependencies for client and server logic.
Mar 9 2023, 10:40 AM
jon requested review of D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 9 2023, 10:40 AM

Mar 8 2023

jon requested review of D7003: [Identity] Add client <-> identity protobuf defintions.
Mar 8 2023, 6:54 PM
jon added a comment to D7003: [Identity] Add client <-> identity protobuf defintions.

Huh wait a user should know their userID, did you guys discard of the concept of a userID entirely because you didn't see it in the whitepaper?

Mar 8 2023, 6:54 PM