Page MenuHomePhabricator

[Identity] Change default port to 50054 to avoid port collision
ClosedPublic

Authored by jon on Thu, Mar 9, 3:53 PM.
Tags
None
Referenced Files
F445266: D7028.id.diff
Sat, Mar 25, 6:39 PM
Unknown Object (File)
Sat, Mar 25, 3:44 AM
Unknown Object (File)
Wed, Mar 22, 6:12 AM
Unknown Object (File)
Tue, Mar 21, 8:24 AM
Unknown Object (File)
Thu, Mar 16, 11:22 PM
Unknown Object (File)
Wed, Mar 15, 9:27 PM
Unknown Object (File)
Sat, Mar 11, 2:17 PM
Unknown Object (File)
Sat, Mar 11, 2:17 PM
Subscribers

Details

Summary

Avoid future port testing or deployment conflicts
by defaulting port something other than default grpc port.

https://linear.app/comm/issue/ENG-3289

Test Plan

Run identity service, keyserver, and native yarn dev

Create new user. Verify identity service is responding.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Mar 9, 4:00 PM
Harbormaster failed remote builds in B17229: Diff 23597!
services/identity/src/main.rs
61 ↗(On Diff #23597)

Just added this because it's pretty jarring to get 0 output initially.

jon requested review of this revision.Thu, Mar 9, 4:16 PM
This revision is now accepted and ready to land.Thu, Mar 9, 10:55 PM
varun added inline comments.
services/identity/src/main.rs
61 ↗(On Diff #23597)

nit: gRPC

jon marked an inline comment as done.

grpc -> gRPC

services/identity/src/main.rs
61 ↗(On Diff #23597)

fair