Page MenuHomePhabricator

[Identity] Change default port to 50054 to avoid port collision
ClosedPublic

Authored by jon on Mar 9 2023, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 2, 10:46 AM
Unknown Object (File)
Thu, Mar 28, 9:55 AM
Unknown Object (File)
Feb 23 2024, 9:37 AM
Unknown Object (File)
Feb 23 2024, 9:35 AM
Unknown Object (File)
Feb 23 2024, 9:11 AM
Unknown Object (File)
Feb 23 2024, 8:07 AM
Unknown Object (File)
Feb 23 2024, 7:01 AM
Unknown Object (File)
Feb 23 2024, 3:05 AM
Subscribers

Details

Summary

Avoid future port testing or deployment conflicts
by defaulting port something other than default grpc port.

https://linear.app/comm/issue/ENG-3289

Test Plan

Run identity service, keyserver, and native yarn dev

Create new user. Verify identity service is responding.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 9 2023, 4:00 PM
Harbormaster failed remote builds in B17229: Diff 23597!
services/identity/src/main.rs
61 ↗(On Diff #23597)

Just added this because it's pretty jarring to get 0 output initially.

This revision is now accepted and ready to land.Mar 9 2023, 10:55 PM
varun added inline comments.
services/identity/src/main.rs
61 ↗(On Diff #23597)

nit: gRPC

jon marked an inline comment as done.

grpc -> gRPC

services/identity/src/main.rs
61 ↗(On Diff #23597)

fair