Page MenuHomePhabricator
Differential D7028

[Identity] Change default port to 50054 to avoid port collision
ClosedPublic
Actions

Authored by jon on Thu, Mar 9, 3:53 PM.
Tags
None
Referenced Files
F445266: D7028.id.diff
Sat, Mar 25, 6:39 PM
Unknown Object (File)
Sat, Mar 25, 3:44 AM
Unknown Object (File)
Wed, Mar 22, 6:12 AM
Unknown Object (File)
Tue, Mar 21, 8:24 AM
Unknown Object (File)
Thu, Mar 16, 11:22 PM
Unknown Object (File)
Wed, Mar 15, 9:27 PM
Unknown Object (File)
Sat, Mar 11, 2:17 PM
Unknown Object (File)
Sat, Mar 11, 2:17 PM
View All 12 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMabfa7ff6229f: [Identity] Change default port to 50054 to avoid port collision
Summary

Avoid future port testing or deployment conflicts
by defaulting port something other than default grpc port.

https://linear.app/comm/issue/ENG-3289

Test Plan

Run identity service, keyserver, and native yarn dev

Create new user. Verify identity service is responding.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jon created this revision.Thu, Mar 9, 3:53 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptThu, Mar 9, 3:54 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Mar 9, 4:00 PM
Harbormaster failed remote builds in B17229: Diff 23597!
jon added inline comments.Thu, Mar 9, 4:13 PM
services/identity/src/main.rs
61 ↗(On Diff #23597)

Just added this because it's pretty jarring to get 0 output initially.

Harbormaster completed remote builds in B17229: Diff 23597.Thu, Mar 9, 4:16 PM
jon requested review of this revision.Thu, Mar 9, 4:16 PM
bartek accepted this revision.Thu, Mar 9, 10:55 PM
This revision is now accepted and ready to land.Thu, Mar 9, 10:55 PM
varun accepted this revision.Thu, Mar 9, 10:59 PM
varun added inline comments.
services/identity/src/main.rs
61 ↗(On Diff #23597)

nit: gRPC

jon updated this revision to Diff 23608.Fri, Mar 10, 8:27 AM
jon marked an inline comment as done.

grpc -> gRPC

Harbormaster completed remote builds in B17238: Diff 23608.Fri, Mar 10, 8:42 AM
jon added inline comments.Fri, Mar 10, 9:00 AM
services/identity/src/main.rs
61 ↗(On Diff #23597)

fair

jon updated this revision to Diff 23610.Fri, Mar 10, 9:03 AM

Rebase on master

Harbormaster completed remote builds in B17240: Diff 23610.Fri, Mar 10, 9:18 AM
Closed by commit rCOMMabfa7ff6229f: [Identity] Change default port to 50054 to avoid port collision (authored by jon). · Explain WhyFri, Mar 10, 9:22 AM
This revision was automatically updated to reflect the committed changes.
jon added a commit: rCOMMabfa7ff6229f: [Identity] Change default port to 50054 to avoid port collision.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
src/
identity_client/
2 lines
services/
2 lines
identity/
src/
2 lines
2 lines

Diff 23611

View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...
View Options

services/docker-compose.yml

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/main.rs

Loading...