HomePhabricator
Diffusion Comm 2e1a4bb63e4e

[native] seperate out each reaction into their own pill

Description

[native] seperate out each reaction into their own pill

Summary:
The next step to redesigning the InlineEngagement component is to split out each reaction into its own pill. In this diff we introduced a regression where we got rid of the spacing between the sidebar pill and the first reaction pill; however, we will address this regression in the very next diff

As mentioned in a previous diff, this diff breaks the chat height measurement. As such this diff and subsequent diffs won't be landed until the rest of the native inline engagement work w/ correct height measurement is completed

Depends on D8497

Test Plan:
Please see the screenshots below

Before:

Screenshot 2023-07-18 at 1.08.24 AM.png (1×960 px, 509 KB)

Screenshot 2023-07-18 at 1.05.52 AM.png (1×960 px, 423 KB)

After:

Screenshot 2023-07-18 at 1.07.37 AM.png (1×960 px, 743 KB)

Screenshot 2023-07-18 at 1.07.48 AM.png (1×1 px, 854 KB)

Reviewers: atul, kamil

Reviewed By: kamil

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8539

Details

Provenance
ginsuAuthored on Jul 17 2023, 10:20 PM
Reviewer
kamil
Differential Revision
D8539: [native] seperate out each reaction into their own pill
Parents
rCOMM14a54ad05d59: [native] split the inline engagement pill into two
Branches
Unknown
Tags
Unknown