Paths

Table of Contentst

Differential D10087

[flow] Convert all remaining Shape to $Partial
ClosedPublic
Actions

Authored by ashoat on Nov 28 2023, 8:39 PM.

Details

Reviewers

michal

Commits

rCOMM3d125225e6b0: [flow] Convert all remaining Shape to $Partial

Summary

Alongside my attempts to replace $Shape with Partial in the preceding diffs, I'm also looking to replace our custom type Shape.

This diff handles all remaining cases, and deletes the lib/types/core.js file, whose only contents was the Shape type.

Depends on D10086

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 28 2023, 8:39 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 28 2023, 8:39 PM

ashoat added a child revision: D10088: [web] Replace {||} with {} in identity-structs.cjs.flow.Nov 28 2023, 8:40 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 28 2023, 8:54 PM

Harbormaster failed remote builds in B24595: Diff 33974!

Rebase for Lint fixes

Harbormaster completed remote builds in B24599: Diff 33978.Nov 28 2023, 10:39 PM

ashoat requested review of this revision.Nov 28 2023, 10:39 PM

michal accepted this revision.Nov 29 2023, 4:26 AM

This revision is now accepted and ready to land.Nov 29 2023, 4:26 AM

Closed by commit rCOMM3d125225e6b0: [flow] Convert all remaining Shape to $Partial (authored by ashoat). · Explain WhyNov 29 2023, 10:23 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM3d125225e6b0: [flow] Convert all remaining Shape to $Partial.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

thread-creator.js

3 lines

scripts/

merge-users.js

3 lines

session/

cookies.js

3 lines

socket/

socket.js

3 lines

updaters/

session-updaters.js

3 lines

thread-updaters.js

3 lines

lib/

hooks/

theme.js

3 lines

media/

file-utils.js

5 lines

types/

11 lines

5 lines

9 lines

3 lines

subscription-types.js

3 lines

thread-types.js

3 lines

utils/

call-server-endpoint.js

5 lines

native/

calendar/

entry.react.js

3 lines

components/

node-height-measurer.react.js

6 lines

tag-input.react.js

3 lines

media/

file-utils.js

5 lines

redux/

action-types.js

5 lines

utils/

animation-utils.js

8 lines

web/

calendar/

entry.react.js

3 lines

media/

encrypted-multimedia.react.js

3 lines

loadable-video.react.js

4 lines

redux/

redux-setup.js

3 lines

Diff 33974

View Options

keyserver/src/creators/thread-creator.js

View Options

keyserver/src/scripts/merge-users.js

View Options

keyserver/src/session/cookies.js

View Options

keyserver/src/socket/socket.js

View Options

keyserver/src/updaters/session-updaters.js

View Options

keyserver/src/updaters/thread-updaters.js

View Options

lib/hooks/theme.js

View Options

lib/media/file-utils.js

View Options

lib/types/core.js

View Options

lib/types/media-types.js

View Options

lib/types/redux-types.js

View Options

lib/types/request-types.js

View Options

lib/types/session-types.js

View Options

lib/types/subscription-types.js

View Options

lib/types/thread-types.js

View Options

lib/utils/call-server-endpoint.js

View Options

native/calendar/entry.react.js

View Options

native/components/node-height-measurer.react.js

View Options

native/components/tag-input.react.js

View Options

native/media/file-utils.js

View Options

native/redux/action-types.js

View Options

native/utils/animation-utils.js

View Options

web/calendar/entry.react.js

View Options

web/media/encrypted-multimedia.react.js

View Options

web/media/loadable-video.react.js

View Options

[flow] Convert all remaining Shape to $PartialClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33974

keyserver/src/creators/thread-creator.js

keyserver/src/scripts/merge-users.js

keyserver/src/session/cookies.js

keyserver/src/socket/socket.js

keyserver/src/updaters/session-updaters.js

keyserver/src/updaters/thread-updaters.js

lib/hooks/theme.js

lib/media/file-utils.js

lib/types/core.js

lib/types/media-types.js

lib/types/redux-types.js

lib/types/request-types.js

lib/types/session-types.js

lib/types/subscription-types.js

lib/types/thread-types.js

lib/utils/call-server-endpoint.js

native/calendar/entry.react.js

native/components/node-height-measurer.react.js

native/components/tag-input.react.js

native/media/file-utils.js

native/redux/action-types.js

native/utils/animation-utils.js

web/calendar/entry.react.js

web/media/encrypted-multimedia.react.js

web/media/loadable-video.react.js

web/redux/redux-setup.js

[flow] Convert all remaining Shape to $Partial
ClosedPublic
Actions

Revision Contents
Changeset List