Page MenuHomePhabricator
Differential D10103

[web] introduce light mode to view invite link modal
ClosedPublic
Actions

Authored by ginsu on Nov 30 2023, 9:12 AM.
Tags
None
Referenced Files
F1798497: D10103.diff
Mon, May 20, 1:41 AM
Unknown Object (File)
Apr 8 2024, 5:12 PM
Unknown Object (File)
Apr 8 2024, 5:12 PM
Unknown Object (File)
Apr 8 2024, 5:12 PM
Unknown Object (File)
Apr 8 2024, 5:12 PM
Unknown Object (File)
Apr 8 2024, 5:12 PM
Unknown Object (File)
Feb 20 2024, 1:24 PM
Unknown Object (File)
Feb 20 2024, 11:46 AM
View All 22 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
atul
rohan
Commits
rCOMM476e0b3ad021: [web] introduce light mode to view invite link modal
Summary

This diff introduces light mode to the view invite link modal

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

Linear task: https://linear.app/comm/issue/ENG-4838/invite-link-modal

Depends on D10101

Test Plan

Please see the screenshots below

dark:

Screenshot 2023-11-30 at 12.15.20 PM.png (1×3 px, 734 KB)

light:

Screenshot 2023-11-30 at 12.15.29 PM.png (1×3 px, 734 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 30 2023, 9:12 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 30 2023, 9:12 AM
ginsu edited the summary of this revision. (Show Details)Nov 30 2023, 9:15 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, atul, rohan.
ginsu added a parent revision: D10101: [web] introduce light mode to manage invite link modal.
ginsu attached a referenced file: F903526: Screenshot 2023-11-30 at 12.15.29 PM.png. (Show Details)
ginsu attached a referenced file: F903525: Screenshot 2023-11-30 at 12.15.20 PM.png. (Show Details)
ginsu added a child revision: D10104: [web] introduce light mode to public link modal.Nov 30 2023, 9:23 AM
Harbormaster completed remote builds in B24648: Diff 34060.Nov 30 2023, 9:39 AM
ginsu requested review of this revision.Nov 30 2023, 9:39 AM
rohan accepted this revision.Nov 30 2023, 1:37 PM
This revision is now accepted and ready to land.Nov 30 2023, 1:37 PM
ginsu updated this revision to Diff 34092.Nov 30 2023, 9:30 PM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 30 2023, 9:32 PM
Closed by commit rCOMM476e0b3ad021: [web] introduce light mode to view invite link modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM476e0b3ad021: [web] introduce light mode to view invite link modal.
Harbormaster completed remote builds in B24678: Diff 34092.Nov 30 2023, 10:11 PM

Revision Contents
Changeset List

PathSize
web/
invite-links/
4 lines

Diff 34094

View Options

web/invite-links/view-invite-link-modal.css

Loading...