Page MenuHomePhabricator
Differential D10192

Pass majorDesktopVersion to platformDetails when creating macos badgeonly notifications.
ClosedPublic
Actions

Authored by marcin on Dec 5 2023, 4:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 5, 10:42 PM
Unknown Object (File)
Fri, Jul 5, 2:38 PM
Unknown Object (File)
Fri, Jul 5, 3:07 AM
Unknown Object (File)
Thu, Jul 4, 12:42 PM
Unknown Object (File)
Tue, Jul 2, 2:50 PM
Unknown Object (File)
Tue, Jul 2, 6:06 AM
Unknown Object (File)
Tue, Jul 2, 5:49 AM
Unknown Object (File)
Tue, Jul 2, 4:12 AM
View All 55 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
Commits
rCOMM9c52607ab18f: Pass majorDesktopVersion to platformDetails when creating macos badgeonly…
Summary

This differential fixes https://linear.app/comm/issue/ENG-6014/macos-badge-only-notifications-are-not-encrypted. The majorDesktopVersion is extracted from
versions object and passed to platformDetails when creating badgeOnly notifications.

Test Plan
  1. Build macOS app without applying this differential.
  2. Ensure that sending badge only notifications does not increment version field in relevant row in olm_sessions table.
  3. Apply this diff and build macOS app again.
  4. Ensure that sending badge only notifications does increment version field in relevant row in olm_sessions table.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Dec 5 2023, 4:21 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 5 2023, 4:21 AM
marcin updated this revision to Diff 34272.Dec 5 2023, 4:27 AM

Rebase

Harbormaster completed remote builds in B24798: Diff 34271.Dec 5 2023, 4:40 AM
Harbormaster completed remote builds in B24799: Diff 34272.Dec 5 2023, 4:50 AM
marcin requested review of this revision.Dec 5 2023, 4:50 AM
michal accepted this revision.Dec 5 2023, 5:46 AM
This revision is now accepted and ready to land.Dec 5 2023, 5:46 AM
marcin updated this revision to Diff 34275.Dec 5 2023, 5:57 AM

Enhance variable naming in conditions that determine whether notification should be encrypted.

Harbormaster completed remote builds in B24802: Diff 34275.Dec 5 2023, 6:18 AM
marcin updated this revision to Diff 34279.Dec 5 2023, 6:20 AM

Rebase

marcin added a parent revision: D10188: Put collapse key in encrypted MacOS notification payload.Dec 5 2023, 6:21 AM
marcin updated this revision to Diff 34281.Dec 5 2023, 6:49 AM

Rebase before landing

Harbormaster completed remote builds in B24804: Diff 34279.Dec 5 2023, 6:53 AM
Harbormaster completed remote builds in B24806: Diff 34281.Dec 5 2023, 7:17 AM
marcin updated this revision to Diff 34287.Dec 5 2023, 8:40 AM

Rebase before landing

Harbormaster completed remote builds in B24810: Diff 34287.Dec 5 2023, 9:06 AM
Closed by commit rCOMM9c52607ab18f: Pass majorDesktopVersion to platformDetails when creating macos badgeonly… (authored by marcin). · Explain WhyDec 5 2023, 9:11 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM9c52607ab18f: Pass majorDesktopVersion to platformDetails when creating macos badgeonly….

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
4 lines

Diff 34289

View Options

keyserver/src/push/send.js

Loading...