Paths

Table of Contentst

Differential D10192

Pass majorDesktopVersion to platformDetails when creating macos badgeonly notifications.
ClosedPublic
Actions

Authored by marcin on Dec 5 2023, 4:21 AM.

Tags

None

Referenced Files

	F3333693: D10192.id34289.diff
	Thu, Nov 21, 4:49 AM

	F3333692: D10192.id34287.diff
	Thu, Nov 21, 4:49 AM

	F3333691: D10192.id34281.diff
	Thu, Nov 21, 4:49 AM

	F3333690: D10192.id34279.diff
	Thu, Nov 21, 4:49 AM

	F3333689: D10192.id34275.diff
	Thu, Nov 21, 4:49 AM

	F3333688: D10192.id34272.diff
	Thu, Nov 21, 4:49 AM

	F3333687: D10192.id34271.diff
	Thu, Nov 21, 4:49 AM

	F3333680: D10192.id.diff
	Thu, Nov 21, 4:49 AM

Subscribers

Details

Reviewers

michal
kamil

Commits

rCOMM9c52607ab18f: Pass majorDesktopVersion to platformDetails when creating macos badgeonly…

Summary

This differential fixes https://linear.app/comm/issue/ENG-6014/macos-badge-only-notifications-are-not-encrypted. The majorDesktopVersion is extracted from
versions object and passed to platformDetails when creating badgeOnly notifications.

Test Plan

Build macOS app without applying this differential.
Ensure that sending badge only notifications does not increment version field in relevant row in olm_sessions table.
Apply this diff and build macOS app again.
Ensure that sending badge only notifications does increment version field in relevant row in olm_sessions table.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Dec 5 2023, 4:21 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 5 2023, 4:21 AM

Rebase

Harbormaster completed remote builds in B24798: Diff 34271.Dec 5 2023, 4:40 AM

Harbormaster completed remote builds in B24799: Diff 34272.Dec 5 2023, 4:50 AM

marcin requested review of this revision.Dec 5 2023, 4:50 AM

michal accepted this revision.Dec 5 2023, 5:46 AM

This revision is now accepted and ready to land.Dec 5 2023, 5:46 AM

Enhance variable naming in conditions that determine whether notification should be encrypted.

Harbormaster completed remote builds in B24802: Diff 34275.Dec 5 2023, 6:18 AM

Rebase

marcin added a parent revision: D10188: Put collapse key in encrypted MacOS notification payload.Dec 5 2023, 6:21 AM

Rebase before landing

Harbormaster completed remote builds in B24804: Diff 34279.Dec 5 2023, 6:53 AM

Harbormaster completed remote builds in B24806: Diff 34281.Dec 5 2023, 7:17 AM

Rebase before landing

Harbormaster completed remote builds in B24810: Diff 34287.Dec 5 2023, 9:06 AM

Closed by commit rCOMM9c52607ab18f: Pass majorDesktopVersion to platformDetails when creating macos badgeonly… (authored by marcin). · Explain WhyDec 5 2023, 9:11 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM9c52607ab18f: Pass majorDesktopVersion to platformDetails when creating macos badgeonly….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

4 lines

Diff 34289

keyserver/src/push/send.js

Loading...