Page MenuHomePhabricator
Differential D10350

[web] introduce navigation sidebar tooltip
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 12:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 4:30 AM
Unknown Object (File)
Thu, Nov 21, 4:30 AM
Unknown Object (File)
Thu, Nov 21, 4:30 AM
Unknown Object (File)
Thu, Nov 21, 4:30 AM
Unknown Object (File)
Thu, Nov 21, 4:30 AM
Unknown Object (File)
Oct 25 2024, 5:21 PM
Unknown Object (File)
Oct 19 2024, 2:56 AM
Unknown Object (File)
Oct 19 2024, 2:56 AM
View All 68 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMMb05240f9727a: [web] introduce navigation sidebar tooltip
Summary

This diff introduces the navigation sidebar tooltip

For context here is what this looks like on the figma:

Screenshot 2023-12-15 at 3.51.06 AM.png (1×408 px, 102 KB)

Part of https://linear.app/comm/issue/ENG-5948/hovering-over-every-clickable-element-in-this-sidebar-will-have-a

Depends on D10349

Test Plan

Please see screenshot below

Screenshot 2023-12-15 at 3.55.27 AM.png (148×338 px, 12 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 15 2023, 12:50 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2023, 12:50 AM
ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 12:56 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10349: [lib/native/web] convert appendSuffix to useAppendCommunitySuffix.
ginsu attached a referenced file: F951393: Screenshot 2023-12-15 at 3.51.06 AM.png. (Show Details)
ginsu added inline comments.
web/navigation-sidebar/navigation-sidebar-constants.js
3

When we create tooltips, part of the process is that we need to calculate the size of the tooltip. I will introduce that logic later, but preemptively introducing the values for that now

web/theme.css
388

This comment is intentional

Harbormaster completed remote builds in B25107: Diff 34694.Dec 15 2023, 1:49 AM
ginsu requested review of this revision.Dec 15 2023, 1:49 AM
rohan accepted this revision.Dec 15 2023, 8:17 AM
This revision is now accepted and ready to land.Dec 15 2023, 8:17 AM
rohan added inline comments.Dec 15 2023, 8:18 AM
web/navigation-sidebar/navigation-sidebar-constants.js
3–9

Are these values from somewhere in our codebase already or did you get them yourself?

ginsu added inline comments.Dec 15 2023, 12:21 PM
web/navigation-sidebar/navigation-sidebar-constants.js
3–9

Got them from the figma + confirmed with the element inspector. (I inspected the tooltip w/o setting this in style prop.

Also forgot to mention, but I broke the padding by each side so that when we have to calculate the size of the tooltip it will be very clear what is what

ginsu updated this revision to Diff 34741.Dec 15 2023, 12:24 PM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 15 2023, 12:27 PM
Closed by commit rCOMMb05240f9727a: [web] introduce navigation sidebar tooltip (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb05240f9727a: [web] introduce navigation sidebar tooltip.
Harbormaster completed remote builds in B25133: Diff 34741.Dec 15 2023, 12:59 PM

Revision Contents
Changeset List

Diff 34694

View Options

web/navigation-sidebar/navigation-sidebar-constants.js

Loading...
View Options

web/navigation-sidebar/navigation-sidebar-toolitp.react.js

Loading...
View Options

web/navigation-sidebar/navigation-sidebar-tooltip.css

Loading...
View Options

web/theme.css

Loading...