Paths

Table of Contentst

Differential D10401

[comm-lib] Add BlobInfo::from_bytes
ClosedPublic
Actions

Authored by michal on Dec 19 2023, 6:07 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 4, 9:27 PM

	Unknown Object (File)
	Wed, Jul 3, 7:20 AM

	Unknown Object (File)
	Sun, Jun 30, 9:29 PM

	Unknown Object (File)
	Sun, Jun 30, 12:17 AM

	Unknown Object (File)
	Wed, Jun 26, 2:08 PM

	Unknown Object (File)
	Sat, Jun 22, 8:15 AM

	Unknown Object (File)
	Sat, Jun 22, 8:15 AM

	Unknown Object (File)
	Sat, Jun 22, 8:15 AM

View All 35 Files

Subscribers

Details

Reviewers

kamil
bartek

Commits

rCOMMd5146f6df020: [comm-lib] Add BlobInfo::from_bytes

Summary

Small refactor, that makes the code a bit cleaner. This diff also moves the required dependencies (that will also be used in the next diff). The ReportContent struct that uses this function will also be moved to comm-lib, as it will be useful for the backup service (keeping logs in either blob or dynamodb).

Test Plan

cargo check in report service

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Dec 19 2023, 6:07 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 19 2023, 6:07 AM

michal added a child revision: D10402: [report service] Move ReportContent to lib.Dec 19 2023, 6:13 AM

Harbormaster completed remote builds in B25218: Diff 34838.Dec 19 2023, 7:11 AM

michal requested review of this revision.Dec 19 2023, 7:11 AM

bartek accepted this revision.Dec 20 2023, 12:05 AM

This revision is now accepted and ready to land.Dec 20 2023, 12:05 AM

Closed by commit rCOMMd5146f6df020: [comm-lib] Add BlobInfo::from_bytes (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJan 8 2024, 7:20 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMd5146f6df020: [comm-lib] Add BlobInfo::from_bytes.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

services/

backup/

blob/

commtest/

identity/

reports/

2 lines

src/

database/

8 lines

tunnelbroker/

shared/

backup_client/

comm-lib/

3 lines

src/

blob/

11 lines

Diff 35382

native/native_rust_library/Cargo.lock

Loading...

services/backup/Cargo.lock

Loading...

services/blob/Cargo.lock

Loading...

services/commtest/Cargo.lock

Loading...

services/identity/Cargo.lock

Loading...

services/reports/Cargo.lock

Loading...

services/reports/Cargo.toml

Loading...

services/reports/src/database/item.rs

Loading...

services/tunnelbroker/Cargo.lock

Loading...

shared/backup_client/Cargo.lock

Loading...

shared/comm-lib/Cargo.lock

Loading...

shared/comm-lib/Cargo.toml

Loading...

shared/comm-lib/src/blob/types.rs

Loading...