Paths

Table of Contentst

Differential D10453

[backup] Implement basic websocket
ClosedPublic
Actions

Authored by michal on Dec 22 2023, 7:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 8, 10:00 PM

	Unknown Object (File)
	Sat, Nov 23, 6:01 AM

	Unknown Object (File)
	Nov 16 2024, 7:33 PM

	Unknown Object (File)
	Nov 16 2024, 7:33 PM

	Unknown Object (File)
	Nov 16 2024, 7:33 PM

	Unknown Object (File)
	Nov 16 2024, 7:33 PM

	Unknown Object (File)
	Nov 16 2024, 7:33 PM

	Unknown Object (File)
	Nov 16 2024, 7:33 PM

Subscribers

Details

Reviewers

bartek
kamil

Commits

rCOMM129062df7844: [backup] Implement basic websocket

Summary

ENG-5329, ENG-5330

This is the basic websocket setup that will be used for adding download/upload log requests. It will be expanded it the future diffs.

Depends on D10452

Test Plan

made a new websocket connection
tested if responding to pings with pongs kept the socket alive
tested sending a binary message and checking if we got it back

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Dec 22 2023, 7:51 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 22 2023, 7:51 AM

michal added inline comments.Dec 22 2023, 7:55 AM

services/backup/src/http/handlers/log.rs
104–135 ↗	(On Diff #34990)	This is implemented based on one of the actix examples. I had trouble testing this behaviour, I think this is more of an implementation detail for web socket clients (e.g. I've read that chrome sometimes sends them). They weren't sent with my testing with tungstenite. Not sure if I should leave them or remove this code and just return an error.

michal added a child revision: D10456: [backup] Log upload endpoint.Dec 22 2023, 7:59 AM

Harbormaster completed remote builds in B25328: Diff 34990.Dec 22 2023, 8:11 AM

michal requested review of this revision.Dec 22 2023, 8:11 AM

bartek accepted this revision.Jan 5 2024, 12:27 AM

bartek added inline comments.

services/backup/src/http/handlers/log.rs
40 ↗	(On Diff #34990)	I prefer this
103 ↗	(On Diff #34990)
104–135 ↗	(On Diff #34990)	I'd leave it as is and just add a comment above

This revision is now accepted and ready to land.Jan 5 2024, 12:27 AM

Rebase

Respond to review

Remove Arcs

Fix rebase error

Harbormaster failed remote builds in B25596: Diff 35365!Jan 8 2024, 6:27 AM

Harbormaster failed remote builds in B25597: Diff 35366!Jan 8 2024, 6:35 AM

Harbormaster failed remote builds in B25598: Diff 35367!Jan 8 2024, 6:40 AM

Harbormaster failed remote builds in B25599: Diff 35368!Jan 8 2024, 6:44 AM

This revision was landed with ongoing or failed builds.Jan 8 2024, 7:20 AM

Closed by commit rCOMM129062df7844: [backup] Implement basic websocket (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM129062df7844: [backup] Implement basic websocket.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

1 line

http/

handlers/

154 lines

12 lines

Diff 35389

services/backup/src/constants.rs

Loading...

services/backup/src/http/handlers/log.rs

Loading...

services/backup/src/http/mod.rs

Loading...