Details
Details
- Reviewers
bartek kamil - Commits
- rCOMM129062df7844: [backup] Implement basic websocket
- made a new websocket connection
- tested if responding to pings with pongs kept the socket alive
- tested sending a binary message and checking if we got it back
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/src/http/handlers/log.rs | ||
|---|---|---|
| 104–135 | This is implemented based on one of the actix examples. I had trouble testing this behaviour, I think this is more of an implementation detail for web socket clients (e.g. I've read that chrome sometimes sends them). They weren't sent with my testing with tungstenite. Not sure if I should leave them or remove this code and just return an error. | |