Page MenuHomePhabricator
Differential D10432

[lib/web/native] Convert getMentionTypeaheadUserSuggestions into a hook
ClosedPublic
Actions

Authored by rohan on Dec 21 2023, 1:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 4, 1:00 AM
Unknown Object (File)
Fri, Apr 4, 12:13 AM
Unknown Object (File)
Thu, Mar 20, 4:41 AM
Unknown Object (File)
Mar 2 2025, 10:25 AM
Unknown Object (File)
Feb 26 2025, 10:57 AM
Unknown Object (File)
Feb 21 2025, 11:07 AM
Unknown Object (File)
Feb 15 2025, 11:09 AM
Unknown Object (File)
Feb 15 2025, 11:09 AM
View All 79 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
inka
Commits
rCOMM165d35ab1a3f: [lib/web/native] Convert getMentionTypeaheadUserSuggestions into a hook
Summary

This is some feedback provided in https://phab.comm.dev/D10387#inline-63506. This diff converts getMentionTypeaheadUserSuggestions into a hook that is consumed in both web and native.

Addressess ENG-6278

Depends on D10407

Test Plan

Made sure the @ mentioning for users and chats still looked fine, nothing seemed slow or out of place. Also opened up the Chrome console to make sure no React warnings were appearing.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Dec 21 2023, 1:37 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 21 2023, 1:37 PM
rohan added inline comments.Dec 21 2023, 1:38 PM
lib/shared/mention-utils.js
137–140 ↗(On Diff #34928)

The conversion to a hook here is similar to the conversion I did for useMentionTypeaheadUserSuggestions above

Harbormaster completed remote builds in B25291: Diff 34928.Dec 21 2023, 1:55 PM
rohan requested review of this revision.Dec 21 2023, 1:55 PM
atul accepted this revision.Dec 21 2023, 4:26 PM
This revision is now accepted and ready to land.Dec 21 2023, 4:26 PM
Closed by commit rCOMM165d35ab1a3f: [lib/web/native] Convert getMentionTypeaheadUserSuggestions into a hook (authored by rohan). · Explain WhyDec 22 2023, 10:28 AM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM165d35ab1a3f: [lib/web/native] Convert getMentionTypeaheadUserSuggestions into a hook.

Revision Contents
Changeset List

PathSize
lib/
shared/
37 lines
native/
chat/
31 lines
web/
chat/
30 lines

Diff 35002

View Options

lib/shared/mention-utils.js

Show All 18 Linesjsi::Array KeyserverStore::parseDBDataStore(
std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const { std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const {
size_t numKeyservers = keyserversVectorPtr->size(); size_t numKeyservers = keyserversVectorPtr->size();
jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers); jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers);
size_t writeIdx = 0; size_t writeIdx = 0;
for (const KeyserverInfo &keyserver : *keyserversVectorPtr) { for (const KeyserverInfo &keyserver : *keyserversVectorPtr) {
jsi::Object jsiKeyserver = jsi::Object(rt); jsi::Object jsiKeyserver = jsi::Object(rt);
jsiKeyserver.setProperty(rt, "id", keyserver.id); jsiKeyserver.setProperty(rt, "id", keyserver.id);
jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info); jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info);
jsiKeyserver.setProperty(
rt, "syncedKeyserverInfo", keyserver.synced_keyserver_info);
jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver); jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver);
} }
return jsiKeyservers; return jsiKeyservers;
} }
std::vector<std::unique_ptr<KeyserverStoreOperationBase>> std::vector<std::unique_ptr<KeyserverStoreOperationBase>>
KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
Show All 20 Lines for (size_t idx = 0; idx < operations.size(rt); idx++) {
} else if (opType == REMOVE_ALL_OPERATION) { } else if (opType == REMOVE_ALL_OPERATION) {
keyserverStoreOps.push_back( keyserverStoreOps.push_back(
std::make_unique<RemoveAllKeyserversOperation>()); std::make_unique<RemoveAllKeyserversOperation>());
} else if (opType == REPLACE_OPERATION) { } else if (opType == REPLACE_OPERATION) {
jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt); jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt);
std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt); std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt);
std::string keyserver_info = std::string keyserver_info =
payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt); payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt);
std::string synced_keyserver_info =
payloadObj.getProperty(rt, "syncedKeyserverInfo")
.asString(rt)
.utf8(rt);
KeyserverInfo keyserver{id, keyserver_info}; KeyserverInfo keyserver{id, keyserver_info, synced_keyserver_info};
keyserverStoreOps.push_back( keyserverStoreOps.push_back(
std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver))); std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver)));
} else { } else {
throw std::runtime_error("unsupported operation: " + opType); throw std::runtime_error("unsupported operation: " + opType);
} }
}; };
return keyserverStoreOps; return keyserverStoreOps;
} }
} // namespace comm } // namespace comm
View Options

native/chat/chat-input-bar.react.js

Show All 18 Linesjsi::Array KeyserverStore::parseDBDataStore(
std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const { std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const {
size_t numKeyservers = keyserversVectorPtr->size(); size_t numKeyservers = keyserversVectorPtr->size();
jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers); jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers);
size_t writeIdx = 0; size_t writeIdx = 0;
for (const KeyserverInfo &keyserver : *keyserversVectorPtr) { for (const KeyserverInfo &keyserver : *keyserversVectorPtr) {
jsi::Object jsiKeyserver = jsi::Object(rt); jsi::Object jsiKeyserver = jsi::Object(rt);
jsiKeyserver.setProperty(rt, "id", keyserver.id); jsiKeyserver.setProperty(rt, "id", keyserver.id);
jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info); jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info);
jsiKeyserver.setProperty(
rt, "syncedKeyserverInfo", keyserver.synced_keyserver_info);
jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver); jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver);
} }
return jsiKeyservers; return jsiKeyservers;
} }
std::vector<std::unique_ptr<KeyserverStoreOperationBase>> std::vector<std::unique_ptr<KeyserverStoreOperationBase>>
KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
Show All 20 Lines for (size_t idx = 0; idx < operations.size(rt); idx++) {
} else if (opType == REMOVE_ALL_OPERATION) { } else if (opType == REMOVE_ALL_OPERATION) {
keyserverStoreOps.push_back( keyserverStoreOps.push_back(
std::make_unique<RemoveAllKeyserversOperation>()); std::make_unique<RemoveAllKeyserversOperation>());
} else if (opType == REPLACE_OPERATION) { } else if (opType == REPLACE_OPERATION) {
jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt); jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt);
std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt); std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt);
std::string keyserver_info = std::string keyserver_info =
payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt); payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt);
std::string synced_keyserver_info =
payloadObj.getProperty(rt, "syncedKeyserverInfo")
.asString(rt)
.utf8(rt);
KeyserverInfo keyserver{id, keyserver_info}; KeyserverInfo keyserver{id, keyserver_info, synced_keyserver_info};
keyserverStoreOps.push_back( keyserverStoreOps.push_back(
std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver))); std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver)));
} else { } else {
throw std::runtime_error("unsupported operation: " + opType); throw std::runtime_error("unsupported operation: " + opType);
} }
}; };
return keyserverStoreOps; return keyserverStoreOps;
} }
} // namespace comm } // namespace comm
View Options

web/chat/chat-input-bar.react.js

Show All 18 Linesjsi::Array KeyserverStore::parseDBDataStore(
std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const { std::shared_ptr<std::vector<KeyserverInfo>> keyserversVectorPtr) const {
size_t numKeyservers = keyserversVectorPtr->size(); size_t numKeyservers = keyserversVectorPtr->size();
jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers); jsi::Array jsiKeyservers = jsi::Array(rt, numKeyservers);
size_t writeIdx = 0; size_t writeIdx = 0;
for (const KeyserverInfo &keyserver : *keyserversVectorPtr) { for (const KeyserverInfo &keyserver : *keyserversVectorPtr) {
jsi::Object jsiKeyserver = jsi::Object(rt); jsi::Object jsiKeyserver = jsi::Object(rt);
jsiKeyserver.setProperty(rt, "id", keyserver.id); jsiKeyserver.setProperty(rt, "id", keyserver.id);
jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info); jsiKeyserver.setProperty(rt, "keyserverInfo", keyserver.keyserver_info);
jsiKeyserver.setProperty(
rt, "syncedKeyserverInfo", keyserver.synced_keyserver_info);
jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver); jsiKeyservers.setValueAtIndex(rt, writeIdx++, jsiKeyserver);
} }
return jsiKeyservers; return jsiKeyservers;
} }
std::vector<std::unique_ptr<KeyserverStoreOperationBase>> std::vector<std::unique_ptr<KeyserverStoreOperationBase>>
KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) KeyserverStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
Show All 20 Lines for (size_t idx = 0; idx < operations.size(rt); idx++) {
} else if (opType == REMOVE_ALL_OPERATION) { } else if (opType == REMOVE_ALL_OPERATION) {
keyserverStoreOps.push_back( keyserverStoreOps.push_back(
std::make_unique<RemoveAllKeyserversOperation>()); std::make_unique<RemoveAllKeyserversOperation>());
} else if (opType == REPLACE_OPERATION) { } else if (opType == REPLACE_OPERATION) {
jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt); jsi::Object payloadObj = op.getProperty(rt, "payload").asObject(rt);
std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt); std::string id = payloadObj.getProperty(rt, "id").asString(rt).utf8(rt);
std::string keyserver_info = std::string keyserver_info =
payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt); payloadObj.getProperty(rt, "keyserverInfo").asString(rt).utf8(rt);
std::string synced_keyserver_info =
payloadObj.getProperty(rt, "syncedKeyserverInfo")
.asString(rt)
.utf8(rt);
KeyserverInfo keyserver{id, keyserver_info}; KeyserverInfo keyserver{id, keyserver_info, synced_keyserver_info};
keyserverStoreOps.push_back( keyserverStoreOps.push_back(
std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver))); std::make_unique<ReplaceKeyserverOperation>(std::move(keyserver)));
} else { } else {
throw std::runtime_error("unsupported operation: " + opType); throw std::runtime_error("unsupported operation: " + opType);
} }
}; };
return keyserverStoreOps; return keyserverStoreOps;
} }
} // namespace comm } // namespace comm