Page MenuHomePhabricator

[web] introduce add button component
ClosedPublic

Authored by ginsu on Dec 21 2023, 7:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 8 2024, 7:12 PM
Unknown Object (File)
Apr 8 2024, 7:12 PM
Unknown Object (File)
Apr 8 2024, 7:12 PM
Unknown Object (File)
Apr 8 2024, 7:11 PM
Unknown Object (File)
Mar 6 2024, 10:46 PM
Unknown Object (File)
Mar 6 2024, 10:45 PM
Unknown Object (File)
Mar 6 2024, 10:44 PM
Unknown Object (File)
Mar 6 2024, 9:53 PM
Subscribers

Details

Summary

The new web app design uses this add button in several places. Rather than copy + paste this logic in all those places, I built this component that can be reused where we need this add button.

Test Plan

flow + confirmed that the prexisting add button in the keyserver selection list has no regressions

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

web/components/add-button.react.js
18 ↗(On Diff #34954)

This change from 26 to 24 is intentional. In the designs this button is 24x24, must have made this mistake when working on the keyserver selection screens

Screenshot 2023-12-21 at 10.04.38 PM.png (426×1 px, 46 KB)

ginsu requested review of this revision.Dec 21 2023, 7:25 PM
This revision is now accepted and ready to land.Dec 26 2023, 5:21 PM

update + rebase before landing

This revision was landed with ongoing or failed builds.Dec 27 2023, 12:49 PM
This revision was automatically updated to reflect the committed changes.