[lib] rename register -> keyserver register
ClosedPublic
Actions

Authored by varun on Dec 22 2023, 3:27 AM.

Details

Reviewers

inka
tomek
ashoat

Commits

rCOMM339b13b80a74: [lib] rename register -> keyserver register

Summary

since i'm about to introduce an identity register action, i need to rename the existing register action to make it clear that it's for the existing keyserver registration workflow.

Test Plan

no flow errors

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Dec 22 2023, 3:27 AM

Harbormaster completed remote builds in B25314: Diff 34967.Dec 22 2023, 3:45 AM

varun requested review of this revision.Dec 22 2023, 3:45 AM

Wondering about the consequences of this rename. It feels like it could break the compatibility of our reports - an older report could contain one of registerActionTypes actions that can't be recognized by the more recent code.

In D10440#301964, @tomek wrote:

Wondering about the consequences of this rename. It feels like it could break the compatibility of our reports - an older report could contain one of registerActionTypes actions that can't be recognized by the more recent code.

When attempting to load a Redux state from an error report, you should always make sure you're running the same codeVersion locally that that report came from.

This revision is now accepted and ready to land.Dec 22 2023, 7:24 AM

varun added a child revision: D10454: [lib] add identity register action.Dec 22 2023, 7:54 AM

Closed by commit rCOMM339b13b80a74: [lib] rename register -> keyserver register (authored by varun). · Explain WhyJan 16 2024, 11:19 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM339b13b80a74: [lib] rename register -> keyserver register.