Paths

Table of Contentst

Differential D10443

[comm-lib] Re-export AWS types
ClosedPublic
Actions

Authored by bartek on Dec 22 2023, 5:39 AM.

Tags

None

Referenced Files

	F3392384: D10443.diff
	Sat, Nov 30, 8:31 AM

	Unknown Object (File)
	Mon, Nov 18, 5:02 PM

	Unknown Object (File)
	Mon, Nov 18, 12:25 PM

	Unknown Object (File)
	Sat, Nov 16, 1:45 PM

	Unknown Object (File)
	Tue, Nov 12, 5:29 PM

	Unknown Object (File)
	Fri, Nov 8, 12:20 AM

	Unknown Object (File)
	Wed, Nov 6, 7:56 PM

	Unknown Object (File)
	Oct 28 2024, 5:00 AM

View All 74 Files

Subscribers

Details

Reviewers

michal
kamil
varun

Commits

rCOMM94128fdce021: [comm-lib] Re-export AWS types

Summary

This was one time suggested by Jon that until we have cargo workspace, we can have AWS dependencies inside comm-lib and use exports from there in our services.
This is a first step towards that.
Also removed unnecessary aws-types dependency, it is already included as a part of aws-config.

Test Plan

Services compile

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 22 2023, 5:39 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 22 2023, 5:39 AM

bartek added a child revision: D10444: [services] Use comm-lib aws in Tunnelbroker.Dec 22 2023, 5:42 AM

bartek published this revision for review.Dec 22 2023, 5:56 AM

bartek added inline comments.

shared/comm-lib/Cargo.toml
48	This is already included inside `aws-config`
shared/comm-lib/src/lib.rs
26–28	Maybe it's worth re-exporting `DynamoDBClient` too?

Harbormaster completed remote builds in B25317: Diff 34971.Dec 22 2023, 5:58 AM

michal accepted this revision.Jan 2 2024, 3:00 AM

michal added inline comments.

shared/comm-lib/src/lib.rs
26–28	I think it makes sense (even just so it has a shorter name).

This revision is now accepted and ready to land.Jan 2 2024, 3:00 AM

Re-export DynamoDBClient

Harbormaster completed remote builds in B25531: Diff 35278.Jan 5 2024, 2:11 AM

Closed by commit rCOMM94128fdce021: [comm-lib] Re-export AWS types (authored by bartek). · Explain WhyJan 5 2024, 2:25 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM94128fdce021: [comm-lib] Re-export AWS types.

kamil mentioned this in D10366: [services] update `Cargo.lock` files.Jan 8 2024, 4:55 AM

Revision Contents
Changeset List

Path

Size

shared/

comm-lib/

8 lines

src/

11 lines

Diff 34971

shared/comm-lib/Cargo.lock

Loading...

shared/comm-lib/Cargo.toml

Loading...

shared/comm-lib/src/lib.rs

Loading...