[lib] add identity register action
ClosedPublic
Actions

Authored by varun on Dec 22 2023, 3:54 PM.

Details

Reviewers

Commits

rCOMM011839e02349: [lib] add identity register action

Summary

since this action is native-specific, i've created a new interface for native-only client methods.

Depends on D10440

Test Plan

successfully dispatched the action on native and registered a new account with staging identity service

Repository

rCOMM Comm

Branch

deleteuser (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

varun requested review of this revision.Dec 22 2023, 4:14 PM

i'll re-request review after i put up the diff with the actual useIdentityRegister callsite in a sec

Where is the diff stack here? You're using types that are defined in neither the diff stack nor on master...

lib/actions/user-actions.js
27	Where is this type defined?
246	Why is this returned a string if it's just going to get parsed immediately? Where is `registerUser` defined?

lib/actions/user-actions.js
27	it's defined below in `lib/types/identity-service-types.js`
246	it's because we return a string in `CommRustModule` due to Rust limitations it's defined in `CommRustModule`

This comment has been deleted.

lib/types/identity-service-types.js
31	This needs to extend `IdentityServiceClient`

lib/actions/user-actions.js
259	Where does the rest of `CurrentUserInfo` come from if not from identity?

lib/actions/user-actions.js
259	Related discussion: https://linear.app/comm/issue/ENG-4210/handle-avatars-in-currentuserinfo#comment-6bcc3e2a It looks like we at least want the username to be returned here

lib/actions/user-actions.js
259	the client provides the username when it registers. for the time being we'll have to continue to get settings / avatar from the keyserver

lib/actions/user-actions.js
259	ah i understand your question better now. yes, we should return username here as well so that the reducers can use it

lib/actions/user-actions.js
259	Can you also rename `userId` to `userID`? This is the way we usually name variables in our JS codebase

address feedback

remove accidental export

lib/types/identity-service-types.js
25 ↗	(On Diff #35581)	talked to @tomek about this and we agreed that making this method optional on both platforms and providing it only on native is the best option. it forces the developer to think about whether this method is actually available before using it