Enable e2e Windows notifications to public users
ClosedPublic
Actions

Authored by marcin on Dec 28 2023, 10:45 AM.

Details

Reviewers

inka
atul

Commits

rCOMM912ce281d9f3: Enable e2e Windows notifications to public users

Summary

THis differential releases E2E encrypted Windows notifications to public users.

Test Plan

Build production Windows and keyserver.
Ensure notifications are encrypted (check in MariaDB console, by querying olm_sessions table, that version column for row associated with current cookieID

is incrementing with each notif).

Previously testing e2e Windows notifs on production required to manually remove isStaffOrDev checks.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Dec 28 2023, 10:45 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 28 2023, 10:45 AM

marcin added a parent revision: D10482: Enable e2e MacOS notifications to public users.Dec 28 2023, 10:46 AM

Harbormaster completed remote builds in B25378: Diff 35057.Dec 28 2023, 11:21 AM

marcin requested review of this revision.Dec 28 2023, 11:21 AM

Have pretty much zero context on how notifications work on Windows, but this seems like a reasonable flip the switch diff. (Would make sense to get another accept before landing if there's more going on here)

This revision is now accepted and ready to land.Dec 30 2023, 2:07 AM

Rebase before landing

Harbormaster completed remote builds in B25456: Diff 35165.Jan 3 2024, 10:02 AM

Closed by commit rCOMM912ce281d9f3: Enable e2e Windows notifications to public users (authored by marcin). · Explain WhyJan 3 2024, 10:19 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM912ce281d9f3: Enable e2e Windows notifications to public users.