Page MenuHomePhabricator

[web] update the chat tabs ui
AcceptedPublic

Authored by ginsu on Jan 4 2024, 3:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 3, 10:51 AM
Unknown Object (File)
Wed, Sep 18, 4:48 AM
Unknown Object (File)
Wed, Sep 18, 12:55 AM
Unknown Object (File)
Wed, Sep 18, 12:55 AM
Unknown Object (File)
Wed, Sep 18, 12:54 AM
Unknown Object (File)
Aug 27 2024, 5:49 AM
Unknown Object (File)
Aug 27 2024, 4:53 AM
Unknown Object (File)
Aug 27 2024, 2:06 AM
Subscribers

Details

Reviewers
atul
inka
Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

This diff updates the chat tabs ui to match the ui of the new web app redesign. The new chat tabs ui has a lighter background color, here is a screenshot of the figma for reference:

Screenshot 2024-01-04 at 6.34.02 AM.png (408×1 px, 69 KB)

Linear task: https://linear.app/comm/issue/ENG-5969/update-the-tab-bar-ui

Test Plan

Please see the screenshot of the chat tabs

Screenshot 2024-01-04 at 6.29.14 AM.png (256×900 px, 26 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added inline comments.
web/chat/chat-tabs.react.js
60

This will be reintroduced in a subsequent diff that will house this component in the panel body

web/theme.css
341

Intentionally only changed only the dark mode value, towards the end of the UI redesign (later in jan) I will go in and double check the light mode values and update them if needed

ginsu requested review of this revision.Jan 4 2024, 3:46 AM
atul added inline comments.
web/chat/chat-tabs.react.js
43–48

Wouldn't hurt to memoize

web/theme.css
341

Want to put a TODO comment here to match pattern from rest of the stack?

This revision is now accepted and ready to land.Jan 4 2024, 1:27 PM