[web] update chat thread composer ui
AcceptedPublic
Actions

Authored by ginsu on Jan 8 2024, 12:00 AM.

Details

Reviewers

atul
inka

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

This diff updates the chat thread composer ui to match the ui in the new web app redesign. In this diff I did the following:

Added a bottom border inset to the search container when a user is selected
Added a border radius to the hover effect

Linear task: https://linear.app/comm/issue/ENG-5936/message-list-ui-redesign

Depends on D10549

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 8 2024, 12:00 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 8 2024, 12:00 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 8 2024, 12:07 AM

Harbormaster failed remote builds in B25573: Diff 35340!

ginsu edited the summary of this revision. (Show Details)Jan 8 2024, 12:14 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10549: [web] update the thread top bar ui.

ginsu added inline comments.Jan 8 2024, 12:17 AM

web/theme.css
377	Added this variable to the list in this linear task: https://linear.app/comm/issue/ENG-6351/confirm-panel-light-mode-colors

ginsu edited the summary of this revision. (Show Details)Jan 8 2024, 12:18 AM

will make sure ci passes before landing

ginsu added a child revision: D10565: [web] update the chat message list ui.Jan 8 2024, 12:25 AM

ginsu edited the summary of this revision. (Show Details)Jan 8 2024, 12:29 AM

Outside the scope of this diff, but don't love how the search result cell extends beyond the width of the search field.

This revision is now accepted and ready to land.Jan 8 2024, 1:40 PM

Agree with @atul on that one

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-thread-composer.css

13 lines

theme.css

2 lines

Diff 35340

View Options

web/chat/chat-thread-composer.css