Page MenuHomePhabricator
Differential D10565

[web] update the chat message list ui
AcceptedPublic
Actions

Authored by ginsu on Jan 8 2024, 12:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 3:40 AM
Unknown Object (File)
Sun, Nov 3, 3:40 AM
Unknown Object (File)
Sun, Nov 3, 3:40 AM
Unknown Object (File)
Oct 12 2024, 10:51 AM
Unknown Object (File)
Sep 14 2024, 11:02 PM
Unknown Object (File)
Sep 14 2024, 11:01 PM
Unknown Object (File)
Sep 14 2024, 11:01 PM
Unknown Object (File)
Jul 8 2024, 6:57 AM
View All 27 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

This diff updates the chat message list ui to match the ui in the new web app redesign. In this diff I did the following:

  • I removed the set background color so that the thread message list will inherit the panel background color
  • Added 8px of horizontal padding to the messages
  • Added 16px to the bottom of the message list container

Linear task: https://linear.app/comm/issue/ENG-5936/message-list-ui-redesign

Depends on D10564

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 8 2024, 12:16 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 8 2024, 12:16 AM
ginsu edited the summary of this revision. (Show Details)Jan 8 2024, 12:25 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D10564: [web] update chat thread composer ui.
ginsu attached a referenced file: F1043460: Screen Recording 2024-01-08 at 3.20.45 AM.mov. (Show Details)
ginsu edited the summary of this revision. (Show Details)
ginsu edited the summary of this revision. (Show Details)Jan 8 2024, 12:30 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 8 2024, 12:43 AM
Harbormaster failed remote builds in B25574: Diff 35341!
ginsu added a child revision: D10566: [web] update the chat input bar ui.Jan 8 2024, 12:51 AM
ginsu requested review of this revision.Jan 8 2024, 1:13 AM

will make sure ci passes before landing

atul accepted this revision.Jan 8 2024, 1:23 PM
This revision is now accepted and ready to land.Jan 8 2024, 1:23 PM

Revision Contents
Changeset List

Diff 35341

View Options

web/chat/chat-message-list-container.css

Loading...
View Options

web/chat/chat-message-list.css

Loading...