Page MenuHomePhabricator
Differential D10568

[web] fix edit text message container
AcceptedPublic
Actions

Authored by ginsu on Jan 8 2024, 1:03 AM.
Tags
None
Referenced Files
F3374032: D10568.diff
Tue, Nov 26, 1:22 PM
Unknown Object (File)
Sat, Nov 23, 3:49 AM
Unknown Object (File)
Sun, Nov 3, 5:42 PM
Unknown Object (File)
Sun, Nov 3, 3:40 AM
Unknown Object (File)
Sun, Nov 3, 3:40 AM
Unknown Object (File)
Sun, Nov 3, 3:40 AM
Unknown Object (File)
Oct 12 2024, 10:50 AM
Unknown Object (File)
Sep 18 2024, 2:36 AM
View All 30 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Summary

When I was testing, the new message list ui I noticed a bug with the edit message experience overflowing off the screen. This diff fixes that

Depends on D10567

Test Plan

Please see the screenshots below

Before:

Screenshot 2024-01-08 at 4.01.23 AM.png (2×3 px, 846 KB)

After:

Screenshot 2024-01-08 at 4.01.40 AM.png (2×3 px, 857 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 8 2024, 1:03 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 8 2024, 1:03 AM
ginsu edited the summary of this revision. (Show Details)Jan 8 2024, 1:04 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D10567: [web] introduce chat message list panel item.
ginsu attached a referenced file: F1043669: Screenshot 2024-01-08 at 4.01.40 AM.png. (Show Details)
ginsu attached a referenced file: F1043668: Screenshot 2024-01-08 at 4.01.23 AM.png. (Show Details)
ginsu published this revision for review.Jan 8 2024, 1:12 AM
ginsu added a child revision: D10569: [web] update the calendar ui.

will make sure ci passes before landing

Harbormaster failed remote builds in B25577: Diff 35344!Jan 8 2024, 1:31 AM
ashoat added a comment.Jan 8 2024, 4:14 AM

I don't love that this value is hard-coded... not enough context here to suggest a better way to do it, though

atul accepted this revision.Jan 8 2024, 12:48 PM
In D10568#305645, @ashoat wrote:

I don't love that this value is hard-coded... not enough context here to suggest a better way to do it, though

We could use viewport width units so it scales to different breakpoints.

We don't want the input growing/shrinking as the user is typing, but I think it's fine to resize if the user resizes the browser?

This revision is now accepted and ready to land.Jan 8 2024, 12:48 PM

Revision Contents
Changeset List

PathSize
web/
chat/
2 lines

Diff 35344

View Options

web/chat/edit-text-message.css

Loading...