[web] introduce light mode to sidebar promote modal
AbandonedPublic
Actions

Authored by ginsu on Jan 8 2024, 1:21 AM.

Details

Reviewers

atul
inka

Summary

This diff introduces the new color design system/light mode to the sidebar promote modal

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

Linear task: https://linear.app/comm/issue/ENG-5038/sidebar-promote-modal

Depends on D10570

Test Plan

Please see screenshots below

dark:

Screenshot 2024-01-08 at 4.21.10 AM.png (2×3 px, 871 KB)

light:

Screenshot 2024-01-08 at 4.20.54 AM.png (2×3 px, 890 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 8 2024, 1:21 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 8 2024, 1:21 AM

ginsu edited the summary of this revision. (Show Details)Jan 8 2024, 1:23 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu attached a referenced file: F1043793: Screenshot 2024-01-08 at 4.20.54 AM.png. (Show Details)

ginsu attached a referenced file: F1043792: Screenshot 2024-01-08 at 4.21.10 AM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D10570: [web] introduce light mode to confirm leave thread modal.

will make sure ci passes before landing

Harbormaster failed remote builds in B25580: Diff 35347!Jan 8 2024, 1:48 AM

atul accepted this revision.Jan 8 2024, 12:33 PM

This revision is now accepted and ready to land.Jan 8 2024, 12:33 PM

D10276 makes this diff obsolete

Revision Contents
Changeset List

Path

Size

web/

modals/

chat/

sidebar-promote-modal.css

3 lines

Diff 35347

View Options

web/modals/chat/sidebar-promote-modal.css

[web] introduce light mode to sidebar promote modalAbandonedPublicActions