Page MenuHomePhabricator

[native] Patch React Native Jfrog Boost download issue
ClosedPublic

Authored by ashoat on Jan 8 2024, 11:46 AM.
Tags
None
Referenced Files
F3356185: D10580.diff
Sat, Nov 23, 5:20 PM
Unknown Object (File)
Sat, Nov 16, 7:33 PM
Unknown Object (File)
Sat, Nov 16, 7:33 PM
Unknown Object (File)
Sat, Nov 16, 7:33 PM
Unknown Object (File)
Sat, Nov 16, 7:33 PM
Unknown Object (File)
Sat, Nov 16, 7:33 PM
Unknown Object (File)
Sat, Nov 16, 7:31 PM
Unknown Object (File)
Oct 14 2024, 10:50 PM
Subscribers

Details

Summary

Resolves ENG-6382. See here for more details.

Test Plan

Android CI should pass if this solves the issue

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/react-native-boost
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat published this revision for review.Jan 8 2024, 11:47 AM

Will make sure CI passes before landing

This revision is now accepted and ready to land.Jan 8 2024, 11:48 AM

React Native team completely ignored Android. Followed instructions here for Android

Unfortunately it looks like many packages we use declare this dependency in their Gradle builds, and we actually do too in native/android/app/build.gradle. This will additionally need to patch expo-modules-core and react-native-reanimated (at least)