Page MenuHomePhabricator
Differential D10585

[lib] Get keyserver keys in a handler
ClosedPublic
Actions

Authored by tomek on Jan 9 2024, 9:18 AM.
Tags
None
Referenced Files
F2145921: D10585.id35452.diff
Sat, Jun 29, 10:58 PM
Unknown Object (File)
Wed, Jun 26, 8:51 AM
Unknown Object (File)
Wed, Jun 26, 5:53 AM
Unknown Object (File)
Tue, Jun 25, 5:11 PM
Unknown Object (File)
Tue, Jun 25, 5:06 PM
Unknown Object (File)
Mon, Jun 24, 8:37 PM
Unknown Object (File)
Sun, Jun 23, 5:18 PM
Unknown Object (File)
Sat, Jun 22, 8:12 PM
View All 42 Files
Subscribers
ashoat

Details

Reviewers
inka
varun
kamil
bartek
Commits
rCOMM4ad7bd556d61: [lib] Get keyserver keys in a handler
Summary

Get identity client from a context and use it to get the keys. This diff doesn't perform anything useful with them, but presents how they are received, and the code will be extended later in the stack.

https://linear.app/comm/issue/ENG-6084/call-the-getkeyserverkeys-in-the-handler

Depends on D10584

Test Plan

Add sole logs that check if the method is properly called.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Jan 9 2024, 9:18 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 9 2024, 9:18 AM
tomek edited the summary of this revision. (Show Details)Jan 9 2024, 9:19 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 9 2024, 9:33 AM
Harbormaster failed remote builds in B25637: Diff 35439!
tomek updated this revision to Diff 35452.Jan 10 2024, 1:28 AM

Fix eslint

Harbormaster completed remote builds in B25643: Diff 35452.Jan 10 2024, 1:54 AM
tomek requested review of this revision.Jan 10 2024, 1:54 AM
tomek updated this revision to Diff 35493.Jan 10 2024, 6:35 AM

Improve error handling

Harbormaster completed remote builds in B25670: Diff 35493.Jan 10 2024, 7:04 AM
varun accepted this revision.Jan 11 2024, 6:21 AM
varun added inline comments.
lib/components/keyserver-connection-handler.js
47 ↗(On Diff #35493)

should we really be logging this?

This revision is now accepted and ready to land.Jan 11 2024, 6:21 AM
tomek added inline comments.Jan 11 2024, 6:45 AM
lib/components/keyserver-connection-handler.js
47 ↗(On Diff #35493)

This should be used to call e.g. Olm, so when it is done, we should no longer log this. But agree, keeping this log doesn't make too much sense - going to remove it.

tomek updated this revision to Diff 35531.Jan 11 2024, 7:26 AM

Avoid console logging the keys

Harbormaster completed remote builds in B25695: Diff 35531.Jan 11 2024, 7:51 AM
Closed by commit rCOMM4ad7bd556d61: [lib] Get keyserver keys in a handler (authored by tomek). · Explain WhyJan 11 2024, 7:54 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM4ad7bd556d61: [lib] Get keyserver keys in a handler.

Revision Contents
Changeset List

PathSize
lib/
components/
22 lines

Diff 35536

View Options

lib/components/keyserver-connection-handler.js

Loading...