[services] [1/n] Add username to KeyserverKeysResponse
ClosedPublic
Actions

Authored by will on Jan 9 2024, 10:07 PM.

Details

Reviewers

varun
bartek
tomek

Commits

rCOMMe33ff4dc833b: [services] [1/n] Add username to KeyserverKeysResponse

Summary

This adds an identity subfield to KeyserverKeysResponse. This allows verification of keyserver username through identity service.

Test Plan

Made a getKeyserverKeys grpc request and confirmed keyserver info + username response

Diff Detail

Repository

rCOMM Comm

Branch

username_keyserver_response

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jan 9 2024, 10:07 PM

will held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 9 2024, 10:07 PM

will added a reviewer: tomek.Jan 9 2024, 10:09 PM

Harbormaster completed remote builds in B25638: Diff 35447.Jan 9 2024, 10:32 PM

Change username to Identity not string

Remove protobuf and username string function

will edited the test plan for this revision. (Show Details)Jan 10 2024, 3:42 PM

will edited the summary of this revision. (Show Details)

will retitled this revision from [services] Add username to KeyserverKeysResponse to [services] [1/n] Add username to KeyserverKeysResponse.

This diff modifies identity and protofiles to add Identity subfield to KeyserverKeysResponse. Awaiting landing of D10587 to include web codegen files on next diff

will published this revision for review.Jan 10 2024, 3:47 PM

Harbormaster completed remote builds in B25684: Diff 35508.Jan 10 2024, 3:55 PM

Harbormaster completed remote builds in B25685: Diff 35509.Jan 10 2024, 4:03 PM

varun accepted this revision.Jan 10 2024, 7:38 PM

varun added inline comments.

services/identity/src/grpc_services/authenticated.rs
219–240	we could probably simplify this by using our `impl TryFrom<DeviceInfoWithAuth<'_>> for OutboundKeyInfo`. would you mind creating a backlog task for this?