Page MenuHomePhabricator

[services] [1/n] Add username to KeyserverKeysResponse
ClosedPublic

Authored by will on Jan 9 2024, 10:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 24, 10:13 AM
Unknown Object (File)
Tue, Oct 22, 1:06 PM
Unknown Object (File)
Tue, Oct 22, 9:00 AM
Unknown Object (File)
Tue, Oct 22, 8:37 AM
Unknown Object (File)
Tue, Oct 22, 8:37 AM
Unknown Object (File)
Tue, Oct 22, 8:37 AM
Unknown Object (File)
Tue, Oct 22, 8:37 AM
Unknown Object (File)
Oct 5 2024, 7:36 PM
Subscribers

Details

Summary

This adds an identity subfield to KeyserverKeysResponse. This allows verification of keyserver username through identity service.

Test Plan

Made a getKeyserverKeys grpc request and confirmed keyserver info + username response

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will held this revision as a draft.

Change username to Identity not string

Remove protobuf and username string function

will edited the summary of this revision. (Show Details)
will retitled this revision from [services] Add username to KeyserverKeysResponse to [services] [1/n] Add username to KeyserverKeysResponse.

This diff modifies identity and protofiles to add Identity subfield to KeyserverKeysResponse. Awaiting landing of D10587 to include web codegen files on next diff

will published this revision for review.Jan 10 2024, 3:47 PM
varun added inline comments.
services/identity/src/grpc_services/authenticated.rs
219–240 ↗(On Diff #35509)

we could probably simplify this by using our impl TryFrom<DeviceInfoWithAuth<'_>> for OutboundKeyInfo. would you mind creating a backlog task for this?

This revision is now accepted and ready to land.Jan 10 2024, 7:38 PM
This revision was automatically updated to reflect the committed changes.
will marked an inline comment as done.
will marked an inline comment as not done.Jan 11 2024, 3:04 PM
will added inline comments.
services/identity/src/grpc_services/authenticated.rs
219–240 ↗(On Diff #35509)