Page MenuHomePhabricator
Differential D10604

[native] Change backup file separator
ClosedPublic
Actions

Authored by michal on Jan 11 2024, 7:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 9:46 PM
Unknown Object (File)
Fri, Mar 7, 10:52 AM
Unknown Object (File)
Feb 28 2025, 10:45 PM
Unknown Object (File)
Feb 28 2025, 10:45 PM
Unknown Object (File)
Feb 24 2025, 1:28 PM
Unknown Object (File)
Jan 24 2025, 10:06 PM
Unknown Object (File)
Dec 27 2024, 7:35 PM
Unknown Object (File)
Dec 27 2024, 7:35 PM
View All 52 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
kamil
Commits
rCOMMb185d9386644: [native] Change backup file separator
Summary

Turns out generateRandomString uses _ as a possible character which conflichs with the current separator so this diff changes the separator to -.

Test Plan

Generaete filenames checked that they have -.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
java/
app/
comm/
android/
fbjni/
4 lines
ios/
Comm/
4 lines

Diff 35534

View Options

native/android/app/src/main/java/app/comm/android/fbjni/PlatformSpecificTools.java

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines
View Options

native/ios/Comm/PlatformSpecificTools.mm

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines onConcludeEntryEditMode = (entryInfo: EntryInfoWithHeight) => {
} }
}; };
keyboardShow = (event: KeyboardEvent) => { keyboardShow = (event: KeyboardEvent) => {
// flatListHeight() factors in the size of the tab bar, // flatListHeight() factors in the size of the tab bar,
// but it is hidden by the keyboard since it is at the bottom // but it is hidden by the keyboard since it is at the bottom
const { bottomInset, tabBarHeight } = this.props.dimensions; const { bottomInset, tabBarHeight } = this.props.dimensions;
const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5; const inputBarHeight = Platform.OS === 'android' ? 37.7 : 35.5;
const keyboardHeight = Platform.select({ const keyboardHeight: number = Platform.select({
// Android doesn't include the bottomInset in this height measurement // Android doesn't include the bottomInset in this height measurement
android: event.endCoordinates.height, android: event.endCoordinates.height,
default: Math.max(event.endCoordinates.height - bottomInset, 0), default: Math.max(event.endCoordinates.height - bottomInset, 0),
}); });
const keyboardShownHeight = const keyboardShownHeight =
inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0); inputBarHeight + Math.max(keyboardHeight - tabBarHeight, 0);
this.keyboardShownHeight = keyboardShownHeight; this.keyboardShownHeight = keyboardShownHeight;
▲ Show 20 Lines • Show All 332 Lines • Show Last 20 Lines