Paths

Table of Contentst

[native] Change backup file separator
ClosedPublic
Actions

Authored by michal on Jan 11 2024, 7:41 AM.

Details

Reviewers

marcin
kamil

Commits

rCOMMb185d9386644: [native] Change backup file separator

Summary

Turns out generateRandomString uses _ as a possible character which conflichs with the current separator so this diff changes the separator to -.

Test Plan

Generaete filenames checked that they have -.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Jan 11 2024, 7:41 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 11 2024, 7:41 AM

michal added a child revision: D10605: [native] Filepath generation for log and userkeys data.Jan 11 2024, 7:46 AM

Harbormaster completed remote builds in B25698: Diff 35534.Jan 11 2024, 8:05 AM

michal requested review of this revision.Jan 11 2024, 8:05 AM

marcin accepted this revision.Jan 12 2024, 2:48 AM

This revision is now accepted and ready to land.Jan 12 2024, 2:48 AM

Closed by commit rCOMMb185d9386644: [native] Change backup file separator (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJan 16 2024, 7:56 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMb185d9386644: [native] Change backup file separator.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

main/

java/

app/

comm/

android/

fbjni/

PlatformSpecificTools.java

4 lines

ios/

Comm/

PlatformSpecificTools.mm

4 lines

Diff 35534

View Options

native/android/app/src/main/java/app/comm/android/fbjni/PlatformSpecificTools.java