Differential D10618

[NativeRustModule] implement uploading prekeys
ClosedPublic
Actions

Authored by kamil on Jan 12 2024, 4:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 5:51 AM

	Unknown Object (File)
	Fri, Nov 8, 5:12 PM

	Unknown Object (File)
	Oct 18 2024, 7:40 AM

	Unknown Object (File)
	Oct 18 2024, 7:40 AM

	Unknown Object (File)
	Oct 18 2024, 7:40 AM

	Unknown Object (File)
	Oct 18 2024, 7:40 AM

	Unknown Object (File)
	Oct 18 2024, 7:40 AM

	Unknown Object (File)
	Oct 18 2024, 7:40 AM

View All 89 Files

Subscribers

Details

Reviewers

marcin
michal
varun

Commits

rCOMMcd87a421e176: [NativeRustModule] implement uploading prekeys

Summary

[ENG-6385]https://linear.app/comm/issue/ENG-6385/implement-native-method-to-refresh-prekeys)

Test Plan

Call this method and test if it works by inspecting staging DDB table

Diff Detail

Repository

Branch

land

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jan 12 2024, 4:40 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 12 2024, 4:40 AM

Harbormaster completed remote builds in B25722: Diff 35570.Jan 12 2024, 5:03 AM

kamil published this revision for review.Jan 15 2024, 2:43 AM

rebase

kamil added a child revision: D10631: [native] implement prekey rotation handler and call Identity.Jan 15 2024, 6:37 AM

Harbormaster completed remote builds in B25766: Diff 35618.Jan 15 2024, 6:54 AM

varun accepted this revision.Jan 15 2024, 12:37 PM

varun added inline comments.

native/native_rust_library/src/lib.rs
1130 ↗	(On Diff #35618)	we shouldn't have made these field names plural in the .proto file. created this task: https://linear.app/comm/issue/ENG-6449/rename-new-content-prekeys-and-new-notif-prekeys-in-proto-file

This revision is now accepted and ready to land.Jan 15 2024, 12:37 PM

rebase

Harbormaster completed remote builds in B25790: Diff 35659.Jan 16 2024, 4:28 AM

rebase

Harbormaster completed remote builds in B25791: Diff 35660.Jan 16 2024, 5:07 AM

rebase

Harbormaster completed remote builds in B25802: Diff 35672.Jan 16 2024, 7:29 AM

Closed by commit rCOMMcd87a421e176: [NativeRustModule] implement uploading prekeys (authored by kamil). · Explain WhyJan 16 2024, 7:32 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMcd87a421e176: [NativeRustModule] implement uploading prekeys.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

68 lines

Diff 35660

native/native_rust_library/src/lib.rs

Loading...