Page MenuHomePhabricator
Differential D10706

Refactor all replace and update queries not to user ORM.
ClosedPublic
Actions

Authored by marcin on Jan 18 2024, 9:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 14, 12:19 AM
Unknown Object (File)
Apr 13 2024, 10:23 PM
Unknown Object (File)
Mar 7 2024, 11:52 AM
Unknown Object (File)
Mar 7 2024, 3:25 AM
Unknown Object (File)
Feb 19 2024, 2:11 PM
Unknown Object (File)
Feb 17 2024, 6:39 PM
Unknown Object (File)
Feb 15 2024, 1:06 PM
Unknown Object (File)
Feb 14 2024, 10:33 AM
View All 12 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
michal
Commits
rCOMMa61616d178cb: Refactor all replace and update queries not to user ORM.
Summary

This differential refactors all replace and update queries not to use ORM.

Test Plan

Execute tests in https://phab.comm.dev/D10711. Replace and update queries are covered there.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jan 18 2024, 9:12 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 18 2024, 9:12 AM
Harbormaster completed remote builds in B25901: Diff 35797.Jan 18 2024, 9:29 AM
marcin requested review of this revision.Jan 18 2024, 9:29 AM
marcin added a child revision: D10705: Refactor all 'get entity by primary key'-like queries not to use ORM.Jan 18 2024, 9:29 AM
marcin removed a child revision: D10705: Refactor all 'get entity by primary key'-like queries not to use ORM.
marcin added a parent revision: D10705: Refactor all 'get entity by primary key'-like queries not to use ORM.
marcin edited the summary of this revision. (Show Details)
marcin edited the test plan for this revision. (Show Details)
marcin added a child revision: D10707: Refactor all remove queries not to use ORM.
kamil accepted this revision.Jan 25 2024, 6:03 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h
113 ↗(On Diff #35797)

shouldn't we free the error?

native/cpp/CommonCpp/DatabaseManagers/entities/Thread.h
70 ↗(On Diff #35797)

I would create couple of functions bindSQLParam(..) with SQL query, index and different types of value and add implementation for each value - this should make it more reusable

This revision is now accepted and ready to land.Jan 25 2024, 6:03 AM
marcin updated this revision to Diff 36352.Jan 30 2024, 9:35 AM
  1. Free error message in executeQuery.
  2. Move binding data to sql query to separate file
Harbormaster failed remote builds in B26304: Diff 36352!Jan 30 2024, 10:15 AM
marcin updated this revision to Diff 36378.Jan 31 2024, 3:23 AM

Fix Android CI

Harbormaster failed remote builds in B26325: Diff 36378!Jan 31 2024, 3:31 AM
Harbormaster completed remote builds in B26325: Diff 36378.Jan 31 2024, 8:36 AM
marcin updated this revision to Diff 36678.Feb 6 2024, 4:47 AM

Rebase before landing

Harbormaster completed remote builds in B26540: Diff 36678.Feb 6 2024, 5:17 AM
marcin updated this revision to Diff 36695.Feb 6 2024, 6:03 AM

Rebase before landing

This revision was landed with ongoing or failed builds.Feb 6 2024, 6:37 AM
Closed by commit rCOMMa61616d178cb: Refactor all replace and update queries not to user ORM. (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMa61616d178cb: Refactor all replace and update queries not to user ORM..
Harbormaster completed remote builds in B26557: Diff 36695.Feb 6 2024, 6:50 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
114 lines
entities/
5 lines
31 lines
5 lines
9 lines
11 lines
5 lines
5 lines
5 lines
5 lines
5 lines
5 lines
15 lines
32 lines
19 lines
5 lines
web/
database/
_generated/

Diff 36706

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/Draft.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/KeyserverInfo.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/Media.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/Message.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/MessageStoreThread.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/Metadata.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/OlmPersistAccount.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/OlmPersistSession.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/PersistItem.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/Report.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/SQLiteDataConverters.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/SQLiteDataConverters.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/Thread.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/UserInfo.h

Loading...
View Options

web/database/_generated/comm-query-executor.js

Loading...
View Options

web/database/_generated/comm_query_executor.wasm

Loading...