Refactor all replace and update queries not to user ORM.
ClosedPublic
Actions

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h
113 ↗	(On Diff #35797)	shouldn't we `free` the error?
native/cpp/CommonCpp/DatabaseManagers/entities/Thread.h
70 ↗	(On Diff #35797)	I would create couple of functions `bindSQLParam(..)` with SQL query, index and different types of value and add implementation for each value - this should make it more reusable

This revision is now accepted and ready to land.Jan 25 2024, 6:03 AM

Free error message in executeQuery.
Move binding data to sql query to separate file

Harbormaster failed remote builds in B26304: Diff 36352!Jan 30 2024, 10:15 AM

Fix Android CI

Harbormaster failed remote builds in B26325: Diff 36378!Jan 31 2024, 3:31 AM

Harbormaster completed remote builds in B26325: Diff 36378.Jan 31 2024, 8:36 AM

Rebase before landing

Harbormaster completed remote builds in B26540: Diff 36678.Feb 6 2024, 5:17 AM

Rebase before landing

This revision was landed with ongoing or failed builds.Feb 6 2024, 6:37 AM

Closed by commit rCOMMa61616d178cb: Refactor all replace and update queries not to user ORM. (authored by marcin). · Explain Why

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMa61616d178cb: Refactor all replace and update queries not to user ORM..

Harbormaster completed remote builds in B26557: Diff 36695.Feb 6 2024, 6:50 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

114 lines

entities/

5 lines

31 lines

5 lines

9 lines

11 lines

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

SQLiteDataConverters.h

15 lines

SQLiteDataConverters.cpp

32 lines

Thread.h

19 lines

UserInfo.h

5 lines

web/

database/

_generated/

comm-query-executor.js

comm_query_executor.wasm

Diff 36706

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

This file was added.

				#pragma once

				#ifndef SQLITE_ENABLE_SESSION
				#define SQLITE_ENABLE_SESSION
				#endif

				#include <sqlite3.h>
				#include <functional>
				#include <vector>

				namespace comm {
				class SQLiteConnectionManager {
				protected:
				sqlite3 *dbConnection;
				static void handleSQLiteError(
				int errorCode,
				const std::string &errorMessagePrefix,
				int expectedResultCode = SQLITE_OK);
				void closeConnectionInternal();

				public:
				SQLiteConnectionManager();
				sqlite3 *getConnection();
				virtual void initializeConnection(
				std::string sqliteFilePath,
				std::function<void(sqlite3 *)> on_db_open_callback);
				virtual void closeConnection();
				virtual ~SQLiteConnectionManager();
				};
				} // namespace comm

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/Draft.h

This file was added.

				#pragma once

				#ifndef SQLITE_ENABLE_SESSION
				#define SQLITE_ENABLE_SESSION
				#endif

				#include <sqlite3.h>
				#include <functional>
				#include <vector>

				namespace comm {
				class SQLiteConnectionManager {
				protected:
				sqlite3 *dbConnection;
				static void handleSQLiteError(
				int errorCode,
				const std::string &errorMessagePrefix,
				int expectedResultCode = SQLITE_OK);
				void closeConnectionInternal();

				public:
				SQLiteConnectionManager();
				sqlite3 *getConnection();
				virtual void initializeConnection(
				std::string sqliteFilePath,
				std::function<void(sqlite3 *)> on_db_open_callback);
				virtual void closeConnection();
				virtual ~SQLiteConnectionManager();
				};
				} // namespace comm

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h

This file was added.

				#pragma once

				#ifndef SQLITE_ENABLE_SESSION
				#define SQLITE_ENABLE_SESSION
				#endif

				#include <sqlite3.h>
				#include <functional>
				#include <vector>

				namespace comm {
				class SQLiteConnectionManager {
				protected:
				sqlite3 *dbConnection;
				static void handleSQLiteError(
				int errorCode,
				const std::string &errorMessagePrefix,
				int expectedResultCode = SQLITE_OK);
				void closeConnectionInternal();

				public:
				SQLiteConnectionManager();
				sqlite3 *getConnection();
				virtual void initializeConnection(
				std::string sqliteFilePath,
				std::function<void(sqlite3 *)> on_db_open_callback);
				virtual void closeConnection();
				virtual ~SQLiteConnectionManager();
				};
				} // namespace comm

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/KeyserverInfo.h

This file was added.

				#pragma once

				#ifndef SQLITE_ENABLE_SESSION
				#define SQLITE_ENABLE_SESSION
				#endif

				#include <sqlite3.h>
				#include <functional>
				#include <vector>

				namespace comm {
				class SQLiteConnectionManager {
				protected:
				sqlite3 *dbConnection;
				static void handleSQLiteError(
				int errorCode,
				const std::string &errorMessagePrefix,
				int expectedResultCode = SQLITE_OK);
				void closeConnectionInternal();

				public:
				SQLiteConnectionManager();
				sqlite3 *getConnection();
				virtual void initializeConnection(
				std::string sqliteFilePath,
				std::function<void(sqlite3 *)> on_db_open_callback);
				virtual void closeConnection();
				virtual ~SQLiteConnectionManager();
				};
				} // namespace comm