Page MenuHomePhabricator
Differential D10705

Refactor all 'get entity by primary key'-like queries not to use ORM
ClosedPublic
Actions

Authored by marcin on Jan 18 2024, 9:11 AM.
Tags
None
Referenced Files
F1828975: D10705.diff
Thu, May 23, 6:11 AM
Unknown Object (File)
Tue, May 21, 11:33 AM
Unknown Object (File)
Tue, May 21, 11:32 AM
Unknown Object (File)
Tue, May 21, 11:32 AM
Unknown Object (File)
Sun, May 19, 12:19 AM
Unknown Object (File)
Tue, May 14, 12:16 AM
Unknown Object (File)
Apr 13 2024, 10:23 PM
Unknown Object (File)
Apr 7 2024, 9:00 PM
View All 18 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
michal
Commits
rCOMM9df56f96b4bf: Refactor all 'get entity by primary key'-like queries not to use ORM
Summary

This differential refactors all get entity by string primary key queries not to use ORM.

Test Plan

Execute tests implemented in https://phab.comm.dev/D10711. get by string primary key queries are covered there.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jan 18 2024, 9:11 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 18 2024, 9:11 AM
marcin added a parent revision: D10704: Refactor all 'getAll...'-like queries not to use ORM..Jan 18 2024, 9:27 AM
Harbormaster completed remote builds in B25900: Diff 35795.Jan 18 2024, 9:28 AM
marcin requested review of this revision.Jan 18 2024, 9:28 AM
marcin edited the summary of this revision. (Show Details)Jan 18 2024, 9:29 AM
marcin edited the test plan for this revision. (Show Details)
marcin added a parent revision: D10706: Refactor all replace and update queries not to user ORM..
marcin removed a parent revision: D10706: Refactor all replace and update queries not to user ORM..
marcin added a child revision: D10706: Refactor all replace and update queries not to user ORM..
kamil accepted this revision.Jan 25 2024, 5:48 AM

Looks good but address comments form D10704 also here

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1417 ↗(On Diff #35795)

we should do something with the camel/snake case here... but probably not in this diff

This revision is now accepted and ready to land.Jan 25 2024, 5:48 AM
marcin updated this revision to Diff 36351.Jan 30 2024, 9:33 AM

Rebase

Harbormaster failed remote builds in B26303: Diff 36351!Jan 30 2024, 10:14 AM
marcin updated this revision to Diff 36377.Jan 31 2024, 3:22 AM

Fix Android CI

Harbormaster completed remote builds in B26324: Diff 36377.Jan 31 2024, 4:01 AM
marcin updated this revision to Diff 36677.Feb 6 2024, 4:46 AM

Rebase before landing

Harbormaster completed remote builds in B26539: Diff 36677.Feb 6 2024, 5:03 AM
marcin updated this revision to Diff 36694.Feb 6 2024, 6:02 AM

Rebase before landing

Harbormaster completed remote builds in B26556: Diff 36694.Feb 6 2024, 6:19 AM
Closed by commit rCOMM9df56f96b4bf: Refactor all 'get entity by primary key'-like queries not to use ORM (authored by marcin). · Explain WhyFeb 6 2024, 6:37 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM9df56f96b4bf: Refactor all 'get entity by primary key'-like queries not to use ORM.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
35 lines
entities/
32 lines
7 lines
7 lines
web/
database/
_generated/

Diff 36705

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/Metadata.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/PersistItem.h

Loading...
View Options

web/database/_generated/comm_query_executor.wasm

Loading...