Page MenuHomePhabricator

Refactor all 'get entity by primary key'-like queries not to use ORM
ClosedPublic

Authored by marcin on Jan 18 2024, 9:11 AM.
Tags
None
Referenced Files
F2019020: D10705.diff
Sun, Jun 16, 4:02 AM
Unknown Object (File)
Wed, Jun 12, 9:32 PM
Unknown Object (File)
Sat, Jun 1, 8:27 AM
Unknown Object (File)
Thu, May 23, 6:11 AM
Unknown Object (File)
Tue, May 21, 11:33 AM
Unknown Object (File)
Tue, May 21, 11:32 AM
Unknown Object (File)
Tue, May 21, 11:32 AM
Unknown Object (File)
Sun, May 19, 12:19 AM
Subscribers

Details

Summary

This differential refactors all get entity by string primary key queries not to use ORM.

Test Plan

Execute tests implemented in https://phab.comm.dev/D10711. get by string primary key queries are covered there.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good but address comments form D10704 also here

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1417 ↗(On Diff #35795)

we should do something with the camel/snake case here... but probably not in this diff

This revision is now accepted and ready to land.Jan 25 2024, 5:48 AM