Page MenuHomePhabricator
Differential D10794

[lib] Refactor set new session in calendar query/filters reducers
ClosedPublic
Actions

Authored by inka on Jan 23 2024, 6:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 1:44 PM
Unknown Object (File)
Fri, Mar 14, 6:16 AM
Unknown Object (File)
Fri, Mar 14, 6:06 AM
Unknown Object (File)
Fri, Mar 14, 4:24 AM
Unknown Object (File)
Fri, Mar 7, 7:36 AM
Unknown Object (File)
Mon, Mar 3, 8:55 AM
Unknown Object (File)
Feb 25 2025, 2:27 PM
Unknown Object (File)
Feb 22 2025, 10:19 AM
View All 87 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM7d6787ea5517: [lib] Refactor set new session in calendar query/filters reducers
Summary

issue: ENG-5767

Test Plan

Dispatched a set new session action, checked that the filters are cleared

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
reducers/
11 lines
14 lines

Diff 36412

View Options

lib/reducers/calendar-filters-reducer.js

Show First 20 Lines • Show All 245 Lines • ▼ Show 20 Lines if (oldLastUpdate < viewer.sessionLastUpdated) {
// or the user restored the client app from a backup. Either way, we should // or the user restored the client app from a backup. Either way, we should
// invalidate the existing session, since the server has assumed that the // invalidate the existing session, since the server has assumed that the
// checkpoint is further along than it is on the client, and might not still // checkpoint is further along than it is on the client, and might not still
// have all of the updates necessary to do an incremental update // have all of the updates necessary to do an incremental update
await setNewSession(viewer, calendarQuery, oldLastUpdate); await setNewSession(viewer, calendarQuery, oldLastUpdate);
return { sessionContinued: false }; return { sessionContinued: false };
} }
if (oldLastUpdate === 0 && viewer.sessionLastUpdated === 0) {
// If both oldLastUpdate and viewer.sessionLastUpdated are 0, that indicates
// either a fresh registration, or a fresh login following a policy update
// that requires acknowledgment. In the latter case, we don't want to leave
// oldLastUpdate as 0, as it might result in a lot of old updates being
// downloaded. So we make sure to use Date.now() for the new session, and
// return { sessionContinued: false } to make sure the client gets a
// stateSyncPayloadTypes.FULL.
await setNewSession(viewer, calendarQuery, Date.now());
return { sessionContinued: false };
}
let comparisonResult = null; let comparisonResult = null;
try { try {
comparisonResult = compareNewCalendarQuery(viewer, calendarQuery); comparisonResult = compareNewCalendarQuery(viewer, calendarQuery);
} catch (e) { } catch (e) {
if (e.message !== 'unknown_error') { if (e.message !== 'unknown_error') {
throw e; throw e;
} }
} }
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines
View Options

lib/reducers/calendar-query-reducer.js

Show First 20 Lines • Show All 245 Lines • ▼ Show 20 Lines if (oldLastUpdate < viewer.sessionLastUpdated) {
// or the user restored the client app from a backup. Either way, we should // or the user restored the client app from a backup. Either way, we should
// invalidate the existing session, since the server has assumed that the // invalidate the existing session, since the server has assumed that the
// checkpoint is further along than it is on the client, and might not still // checkpoint is further along than it is on the client, and might not still
// have all of the updates necessary to do an incremental update // have all of the updates necessary to do an incremental update
await setNewSession(viewer, calendarQuery, oldLastUpdate); await setNewSession(viewer, calendarQuery, oldLastUpdate);
return { sessionContinued: false }; return { sessionContinued: false };
} }
if (oldLastUpdate === 0 && viewer.sessionLastUpdated === 0) {
// If both oldLastUpdate and viewer.sessionLastUpdated are 0, that indicates
// either a fresh registration, or a fresh login following a policy update
// that requires acknowledgment. In the latter case, we don't want to leave
// oldLastUpdate as 0, as it might result in a lot of old updates being
// downloaded. So we make sure to use Date.now() for the new session, and
// return { sessionContinued: false } to make sure the client gets a
// stateSyncPayloadTypes.FULL.
await setNewSession(viewer, calendarQuery, Date.now());
return { sessionContinued: false };
}
let comparisonResult = null; let comparisonResult = null;
try { try {
comparisonResult = compareNewCalendarQuery(viewer, calendarQuery); comparisonResult = compareNewCalendarQuery(viewer, calendarQuery);
} catch (e) { } catch (e) {
if (e.message !== 'unknown_error') { if (e.message !== 'unknown_error') {
throw e; throw e;
} }
} }
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines