[identity] Make device list transactions more flexible
ClosedPublic
Actions

Authored by bartek on Jan 24 2024, 10:01 AM.

Details

Reviewers

varun
michal

Commits

rCOMM0c4a9659cd41: [identity] Make device list transactions more flexible

Summary

I need the "transaction wrapper" to:

Make the additional DB operation optional
Return the resulting device list representation

Depends on D10797

Test Plan

Ran device list integration tests and seen no regressions

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jan 24 2024, 10:01 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 24 2024, 10:01 AM

bartek added a child revision: D10799: [identity] Basic implementation of UpdateDeviceList RPC.Jan 24 2024, 10:05 AM

Harbormaster failed remote builds in B26119: Diff 36090!Jan 24 2024, 10:07 AM

Fix broken rebase

Harbormaster completed remote builds in B26245: Diff 36256.Jan 29 2024, 12:39 PM

bartek published this revision for review.Jan 29 2024, 12:44 PM

bartek added inline comments.

services/identity/src/database/device_list.rs
1039–1041 ↗	(On Diff #36256)	This should've been `symmetric_difference` from the beginning because we want to detect both kinds of inconsistencies here

varun accepted this revision.Jan 30 2024, 3:45 AM

This revision is now accepted and ready to land.Jan 30 2024, 3:45 AM

Closed by commit rCOMM0c4a9659cd41: [identity] Make device list transactions more flexible. · Explain WhyFeb 12 2024, 9:26 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM0c4a9659cd41: [identity] Make device list transactions more flexible.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

device_list.rs

37 lines

Diff 36090

View Options

services/identity/src/database/device_list.rs

[identity] Make device list transactions more flexibleClosedPublicActions