Page MenuHomePhabricator
Differential D10863

[native] Expose GetDeviceListForUser RPC to JS
ClosedPublic
Actions

Authored by bartek on Jan 29 2024, 5:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 3:54 AM
Unknown Object (File)
Sat, May 25, 10:47 PM
Unknown Object (File)
Sat, May 25, 10:47 PM
Unknown Object (File)
Sat, May 25, 10:46 PM
Unknown Object (File)
Sat, May 25, 10:46 PM
Unknown Object (File)
Thu, May 23, 5:34 AM
Unknown Object (File)
Apr 25 2024, 1:13 PM
Unknown Object (File)
Apr 25 2024, 1:13 PM
View All 20 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
kamil
Commits
rCOMMcf34b3be50be: [native] Expose GetDeviceListForUser RPC to JS
Summary

Exposed GetDeviceListForUser RPC to JS via JSI.

Depends on D10862.

Test Plan

Called the method from JS, console.logged the result.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jan 29 2024, 5:27 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 29 2024, 5:27 AM
bartek added a child revision: D10864: [native] Expose UpdateDeviceList RPC to JS.Jan 29 2024, 5:27 AM
Harbormaster completed remote builds in B26248: Diff 36259.Jan 29 2024, 5:47 AM
bartek published this revision for review.Jan 29 2024, 7:11 AM
bartek added inline comments.
native/cpp/CommonCpp/NativeModules/CommRustModule.cpp
423 ↗(On Diff #36259)

There's no easy Option support in C++ - Rust FFI so I decided to use 0 as a special value. All real device lists have timestamp greater than 0 so this doesn't matter

ashoat added inline comments.Jan 29 2024, 11:50 AM
native/cpp/CommonCpp/NativeModules/CommRustModule.cpp
423 ↗(On Diff #36259)

There is std::optional, but I suppose there is a good reason that doesn't work for us

kamil accepted this revision.Jan 31 2024, 2:55 AM
This revision is now accepted and ready to land.Jan 31 2024, 2:55 AM
bartek added inline comments.Jan 31 2024, 2:59 AM
native/cpp/CommonCpp/NativeModules/CommRustModule.cpp
423 ↗(On Diff #36259)

Yes, but there's no API to pass optionals from C++ to Rust.
We would have to do workarounds like 0-1 element vectors, but this would be an overkill for this particular purpose

bartek removed a parent revision: D10862: [identity] Implement RPC for secondary device registration.Feb 12 2024, 12:55 AM
Closed by commit rCOMMcf34b3be50be: [native] Expose GetDeviceListForUser RPC to JS (authored by bartek). · Explain WhyFeb 12 2024, 1:26 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMcf34b3be50be: [native] Expose GetDeviceListForUser RPC to JS.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
7 lines
36 lines
_generated/
native_rust_library/
src/
62 lines
schema/
7 lines

Diff 36976

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...